Adding multi chats panel in `@jupyter/chat` package by nakul-py · Pull Request #262 · jupyterlab/jupyter-chat

nakul-py · 2025-08-08T07:12:38Z

Adding multi chats pannel to @jypyter/chat package and removing it from jyputerlab-chat. Now it can be easily imported and usable in juputerlab-chat and jupyterlite/ai.

Closes Add a multi chats side panel in @jupyter/chat package #261

github-actions · 2025-08-08T07:12:49Z

👈 Launch a Binder on branch nakul-py/jupyter-chat/multichatpanel

brichet · 2025-08-08T08:56:13Z

Thanks @nakul-py for working on this.

I feel like this PR is not ready for review yet (e.g. we should not need the content manager in that chat, IMO).
Don't you think it should be converted to draft?

FYI I added some thoughts about this change in the issues.

nakul-py · 2025-08-12T11:58:50Z

@brichet These things have done:

Defined ready promise in the AbstractChatModel.
Defined IInputToolbarRegistry in @jupyter/chat.
Added the Rename chat button.

Will you Test it now and suggest some improvements?

brichet · 2025-08-12T16:08:46Z

Thanks @nakul-py for updating it.
FYI I won't be able to review it until September.

nakul-py · 2025-08-12T16:30:02Z

Thanks @nakul-py for updating it. FYI I won't be able to review it until September.

Ok @brichet i am looking forward for you to come back

nakul-py · 2025-08-14T08:25:05Z

bot please update snapshots

brichet

Thanks again @nakul-py for working on this, this is not an easy change.

This is not a full review.
My main comment is that there shouldn't be any notion of file/path in the generic multi-chat panel (@jupyter/chat) and section, this is only relevant for the jupyterlab-chat widget.

That said, I don't have a clear view of the best way to create a multi-chat panel in jupyterlab-chat:

we can create a MultiChatPanel with functions in options to create, rename, open (your current implementation)
we can have a new class in jupyterlab-chat that inherits from MultiChatPanel, and overrides some of its methods

If you prefer, I can also take it from now, and push in your PR.

brichet · 2025-09-03T08:51:15Z

packages/jupyter-chat/src/multiChatPanel.tsx

+      }
+
+      const contentsManager = new ContentsManager();
+      await contentsManager.rename(oldPath, newPath);


There shouldn't be any reference to path in this widget.
The notion of file/path is relevant only for jupyterlab-chat, which uses collaborative documents as chat.

brichet · 2025-09-03T08:51:20Z

packages/jupyter-chat/src/multiChatPanel.tsx

+    widget: ChatWidget;
+    path: string;
+    defaultDirectory: string;
+    openChat: (path: string) => void;


This is not used in the ChatSection I think, only in the panel.

openChat is used by moveToMain button.
But moveToMain is actually not used anywhere inside ChatSection, so we should remove it

brichet · 2025-09-03T08:51:30Z

packages/jupyter-chat/src/model.ts

+  /**
+   * Promise that resolves when the model is ready.
+   */
+  readonly ready: Promise<void>;


Suggested change

readonly ready: Promise<void>;

get ready(): Promise<void> {

return this._readyDelegate.promise;

}

We could use a getter here.

brichet · 2025-09-03T08:51:33Z

packages/jupyter-chat/src/model.ts

  private _id: string | undefined;
  private _name: string = '';
  private _config: IConfig;
+  private _readyDelegate: PromiseDelegate<void>;


Suggested change

private _readyDelegate: PromiseDelegate<void>;

private _readyDelegate = new PromiseDelegate<void>();

Not sure it needs to be set in the constructor.

Yes, the constructor doesn’t need to do anything for it.

brichet · 2025-09-03T08:51:35Z

packages/jupyter-chat/src/multiChatPanel.tsx

This widget should probably be located in src/widgets for consistency.

nakul-py · 2025-09-04T03:32:12Z

If you prefer, I can also take it from now, and push in your PR.

Ok @brichet you can also work on this pr and now renaming, opening, closing and movetomain functions all are working fine.

brichet · 2025-09-05T08:05:09Z

If you prefer, I can also take it from now, and push in your PR.

Ok @brichet you can also work on this pr and now renaming, opening, closing and movetomain functions all are working fine.

Thanks @nakul-py, I'll probably push some commits in the next days.

…duplication

…t from the plugin

… to move the chat in the main area

…ptional in the panel, and improve error handling

…hat discovery

brichet · 2025-09-08T14:41:25Z

In the current implementation the muti-chat panel receive an openChat callback, that (1) creates the model from the chat name, and (2) open the chat in the side panel.
To avoid this back and forth (calling a method from the chat panel that perform action on the chat panel), we should probably provide a createModel method, and open the chat from the multi-chat panel itself.

I'll implement it in a follow up PR, to avoid having too many changes in this one.

nakul-py · 2025-09-08T14:45:52Z

In the current implementation the muti-chat panel receive an openChat callback, that (1) creates the model from the chat name, and (2) open the chat in the side panel.
To avoid this back and forth (calling a method from the chat panel that perform action on the chat panel), we should probably provide a createModel method, and open the chat from the multi-chat panel itself.

I'll implement it in a follow up PR, to avoid having too many changes in this one.

Makes sense

jtpio · 2025-09-12T13:40:00Z

Thanks @nakul-py and @brichet!

Should we have this feature available on the ReadTheDocs demo too, so it's easier to test?

https://jupyter-chat--262.org.readthedocs.build/en/262/lite/lab/index.html

…llbacks

… main input, to ensure all the properties are available

… multichat-panel

brichet · 2025-09-15T16:20:51Z

Looks ready @jtpio, tested without issue in jupyter-ai and jupyterlite-ai.

I updated the example to use the multi-chat widget too.

If you think it is fine, we can probably merge this one, than I'll follow up with #262 (comment)

jtpio

Thanks @nakul-py and @brichet!

adding multichats panel

5dd068b

github-actions bot and others added 2 commits August 8, 2025 07:13

Automatic application of license header

eb48176

Adding comments

ffbe6b1

nakul-py marked this pull request as draft August 8, 2025 11:37

adding rename-chat button and ...

fb036f3

nakul-py marked this pull request as ready for review August 12, 2025 11:58

brichet added the enhancement New feature or request label Aug 12, 2025

lint fix

26e3fd7

nakul-py added 2 commits August 15, 2025 17:19

Updating

7118e78

ui tests

1273e27

pr-triage-board bot added this to PR triage (experimental) Aug 25, 2025

brichet reviewed Sep 3, 2025

View reviewed changes

removing content manager from @jupyter/chat package

b1ca944

nakul-py requested a review from brichet September 4, 2025 03:35

brichet added 3 commits September 5, 2025 13:43

Clean some unused code, and change section title class name to avoid …

dff9f94

…duplication

Remove the hook to listen for chat list, in favor to updating the lis…

dfef4e0

…t from the plugin

Remove closeChat and moveToMain commands, and use openInMain callback…

5d932c8

… to move the chat in the main area

brichet marked this pull request as draft September 5, 2025 15:39

brichet added 4 commits September 5, 2025 17:53

Remove rename modal in favor of jupyterlab modal, make the function o…

3266f26

…ptional in the panel, and improve error handling

Renaming

28b7726

Revert wrong snapshot and test update, and fix commands test

08e0a2b

Allow section to have a name different from the chat model name

a9ce515

Update chat list in throtter to avoid conflict

9c7f216

brichet marked this pull request as ready for review September 8, 2025 07:30

brichet added 2 commits September 8, 2025 10:51

Fix the update debouncer

c86ff86

Better handling of chat file change, and increase timeout for first c…

941baa6

…hat discovery

pr-triage-board bot removed this from PR triage (experimental) Sep 11, 2025

pr-triage-board bot added this to PR triage (experimental) Sep 11, 2025

brichet added 5 commits September 15, 2025 14:48

Make callbacks optional, as well as the buttons depending on these ca…

72b12f8

…llbacks

Wait for the chat to be ready before creating the chat context of the…

ea5804a

… main input, to ensure all the properties are available

Add a disposed signal in chat model, and add a default id/icon to the…

85d694b

… multichat-panel

Update the example

2dbf4b7

handle optional getChatNames

1da452a

jtpio approved these changes Sep 15, 2025

View reviewed changes

jtpio merged commit d88742e into jupyterlab:main Sep 15, 2025
12 checks passed

github-project-automation bot moved this to Done in PR triage (experimental) Sep 15, 2025

jtpio mentioned this pull request Sep 15, 2025

Use multi-chats on the ReadTheDocs demo #273

Open

pr-triage-board bot removed this from PR triage (experimental) Sep 15, 2025

nakul-py deleted the multichatpanel branch September 16, 2025 05:03

jtpio mentioned this pull request Sep 16, 2025

Custom typing notification and component #272

Draft

brichet mentioned this pull request Sep 16, 2025

Multichatpanel followup #275

Merged

-  readonly ready: Promise<void>;
+  get ready(): Promise<void> {
+    return this._readyDelegate.promise;
+  }

	private _readyDelegate: PromiseDelegate<void>;
	private _readyDelegate = new PromiseDelegate<void>();

Uh oh!

Comments

Conversation

nakul-py commented Aug 8, 2025

Uh oh!

github-actions bot commented Aug 8, 2025

Uh oh!

brichet commented Aug 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nakul-py commented Aug 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brichet commented Aug 12, 2025

Uh oh!

nakul-py commented Aug 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nakul-py commented Aug 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brichet left a comment

Choose a reason for hiding this comment

Uh oh!

brichet Sep 3, 2025

Choose a reason for hiding this comment

Uh oh!

brichet Sep 3, 2025

Choose a reason for hiding this comment

Uh oh!

nakul-py Sep 3, 2025

Choose a reason for hiding this comment

Uh oh!

brichet Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

brichet Sep 3, 2025

Choose a reason for hiding this comment

Uh oh!

nakul-py Sep 3, 2025

Choose a reason for hiding this comment

Uh oh!

brichet Sep 3, 2025

Choose a reason for hiding this comment

Uh oh!

nakul-py commented Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brichet commented Sep 5, 2025

Uh oh!

brichet commented Sep 8, 2025

Uh oh!

nakul-py commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jtpio commented Sep 12, 2025

Uh oh!

brichet commented Sep 15, 2025

Uh oh!

jtpio left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

brichet commented Aug 8, 2025 •

edited

Loading

nakul-py commented Aug 12, 2025 •

edited

Loading

nakul-py commented Aug 12, 2025 •

edited

Loading

nakul-py commented Aug 14, 2025 •

edited

Loading

brichet Sep 3, 2025 •

edited

Loading

nakul-py commented Sep 4, 2025 •

edited

Loading

nakul-py commented Sep 8, 2025 •

edited

Loading