Custom typing notification and component#272
Draft
brichet wants to merge 6 commits intojupyterlab:mainfrom
Draft
Custom typing notification and component#272brichet wants to merge 6 commits intojupyterlab:mainfrom
brichet wants to merge 6 commits intojupyterlab:mainfrom
Conversation
Contributor
Member
Collaborator
Author
8496348 to
c4a6b68
Compare
c4a6b68 to
ea1f5aa
Compare
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows a custom notification for a "writing" user.
Fixes #263
Changes
@jupyter/chat
ChatModel.IWriterinterface allows atypingIndicator?: string, which is used in place of the default 'is writing' indicationwriterComponent, that can contain a react component to display after each user writing notificationjupyterlab-chat
typingIndicatorwhen theisWritingproperty is setwriterComponentobject, to allow third party extensions to add a component.Example
Using of the new indicator and component with
jupyter-ai.output.webm