Skip to content

chore: Fix/improve OpenXML docx and pptx datasets (OSS-1317)#1331

Merged
merelcht merged 3 commits intokedro-org:mainfrom
Bas-commits:ossprint/1317-OpenXML
Feb 27, 2026
Merged

chore: Fix/improve OpenXML docx and pptx datasets (OSS-1317)#1331
merelcht merged 3 commits intokedro-org:mainfrom
Bas-commits:ossprint/1317-OpenXML

Conversation

@Bas-commits
Copy link
Copy Markdown
Contributor

Description

Complete a subtask of issue #1317, dataset OpenXML

Development notes

Added the os.PathLike type to the openXML dataset

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Updated jsonschema/kedro-catalog-X.XX.json if necessary
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes
  • Received approvals from at least half of the TSC (required for adding a new, non-experimental dataset)

Signed-off-by: Bas Veltenaar <basveltenaar@gmail.com>
Copy link
Copy Markdown
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contribution @Bas-commits !

@merelcht merelcht changed the title Fix/improve OpenXML docx and pptx datasets (OSS-1317) chore: Fix/improve OpenXML docx and pptx datasets (OSS-1317) Feb 27, 2026
@ravi-kumar-pilla ravi-kumar-pilla self-requested a review February 27, 2026 18:20
Comment thread kedro-datasets/kedro_datasets/openxml/docx_dataset.py
Copy link
Copy Markdown
Contributor

@ravi-kumar-pilla ravi-kumar-pilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @Bas-commits

Copy link
Copy Markdown
Contributor

@SajidAlamQB SajidAlamQB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Bas-commits!

Copy link
Copy Markdown
Contributor

@lrcouto lrcouto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you @Bas-commits

@merelcht merelcht merged commit 4f95b52 into kedro-org:main Feb 27, 2026
16 checks passed
celinaczy pushed a commit to celinaczy/kedro-plugins-fork that referenced this pull request Feb 27, 2026
…rg#1331)

Fix/improve OpenXML docx and pptx datasets (OSS-1317)

Signed-off-by: Bas Veltenaar <basveltenaar@gmail.com>
Co-authored-by: Merel Theisen <49397448+merelcht@users.noreply.github.com>
Co-authored-by: Ravi Kumar Pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: celina-czyszczon <celina.czyszczon@justeattakeaway.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants