Skip to content

chore: Fix/improve OpenXML docx and pptx datasets (OSS-1317) #1331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merelcht merged 3 commits into from
Feb 27, 2026
Merged

chore: Fix/improve OpenXML docx and pptx datasets (OSS-1317) #1331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
687b371
Fix/improve OpenXML docx and pptx datasets (OSS-1317)
Bas-commits Feb 27, 2026
b74cb34
Merge branch 'main' into ossprint/1317-OpenXML
merelcht Feb 27, 2026
9da36c6
Merge branch 'main' into ossprint/1317-OpenXML
ravi-kumar-pilla Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion kedro-datasets/kedro_datasets/openxml/docx_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

from __future__ import annotations

import os
from copy import deepcopy
from io import BytesIO
from pathlib import PurePosixPath
Expand Down Expand Up @@ -54,7 +55,7 @@ class DocxDataset(AbstractVersionedDataset[dict, dict]):
def __init__( # noqa: PLR0913
self,
*,
filepath: str,
filepath: str | os.PathLike,
Comment thread
ravi-kumar-pilla marked this conversation as resolved.
version: Version | None = None,
credentials: dict[str, Any] | None = None,
fs_args: dict[str, Any] | None = None,
Expand Down
3 changes: 2 additions & 1 deletion kedro-datasets/kedro_datasets/openxml/pptx_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

from __future__ import annotations

import os
from copy import deepcopy
from io import BytesIO
from pathlib import PurePosixPath
Expand Down Expand Up @@ -55,7 +56,7 @@ class PptxDataset(AbstractVersionedDataset[Presentation, Presentation]):
def __init__( # noqa: PLR0913
self,
*,
filepath: str,
filepath: str | os.PathLike,
version: Version | None = None,
credentials: dict[str, Any] | None = None,
fs_args: dict[str, Any] | None = None,
Expand Down
Loading