feat(web): clarify return type of KeymanEngine.getKeyboardDetails 🧼 🎼#15890
Open
ermshiperete wants to merge 1 commit intofeat/web/keyboardDetailsfrom
Open
feat(web): clarify return type of KeymanEngine.getKeyboardDetails 🧼 🎼#15890ermshiperete wants to merge 1 commit intofeat/web/keyboardDetailsfrom
KeymanEngine.getKeyboardDetails 🧼 🎼#15890ermshiperete wants to merge 1 commit intofeat/web/keyboardDetailsfrom
Conversation
`getKeyboardDetails` can return `null` if `stub` is falsy. This PR changes the return type accordingly to improve type safety. Follows: #15889 Build-bot: skip build:web Test-bot: skip
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
Bot
changed the title
KeymanEngine.getKeyboardDetails 🧼KeymanEngine.getKeyboardDetails 🧼 🎼
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getKeyboardDetailscan returnnullifstubis falsy. This PR changes the return type accordingly to improve type safety.Follows: #15889
Build-bot: skip build:web
Test-bot: skip