Skip to content

feat(web): clarify return type of KeymanEngine.getKeyboardDetails 🧼 🎼 #15890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ermshiperete merged 1 commit into from
Apr 28, 2026
Merged

feat(web): clarify return type of KeymanEngine.getKeyboardDetails 🧼 🎼 #15890

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions web/src/app/browser/src/keymanEngine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,9 +394,8 @@ export class KeymanEngine extends KeymanEngineBase<BrowserConfiguration, Context
* @param {Keyboard} keyboard Keyboard script object
*
* @return {KeyboardDetails} Keyboard details object
*
*/
private getKeyboardDetails(stub: KeyboardStub, keyboard: Keyboard): KeyboardDetails {
private getKeyboardDetails(stub: KeyboardStub, keyboard: Keyboard): KeyboardDetails | null {
// works for both JS and KMX keyboards
return stub && {
Name: stub.KN,
Expand Down
Loading