-
Notifications
You must be signed in to change notification settings - Fork 624
Closed
Labels
good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/feature-request
Description
Problem
As the Eventing TLS feature track describes the feature track leverages a new config-features configuration called transport-encryption.
We should add:
- the new flag in https://github.com/knative/eventing/blob/main/config/core/configmaps/features.yaml with value
disabled - the new flag name in https://github.com/knative/eventing/blob/main/pkg/apis/feature/flag_names.go
- The additional possible flag values: [permissive, strict] in
eventing/pkg/apis/feature/features.go
Lines 30 to 36 in 7ba0648
// Enabled turns on an optional behavior. Enabled Flag = "Enabled" // Disabled turns off an optional behavior. Disabled Flag = "Disabled" // Allowed neither explicitly disables or enables a behavior. // eg. allow a client to control behavior with an annotation or allow a new value through validation. Allowed Flag = "Allowed" - Helper methods like:
func (e Flags) IsPermissiveTransportEncryption() boolandfunc (e Flags) IsStrictTransportEncryption() boolthat would verify whether thetransport-encryptionfeature flag has a specific value.
Time Estimate (optional):
1
Additional context (optional)
/good-first-issue
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/feature-request