Add transport-encryption feature flag by Rahul-Kumar-prog · Pull Request #6845 · knative/eventing

Rahul-Kumar-prog · 2023-04-04T20:45:32Z

Fixes #6836

Proposed Changes

Pre-review Checklist

At least 80% unit test coverage
E2E tests for any new behavior
Docs PR for any user-facing impact
Spec PR for any new API feature
Conformance test for any change to the spec

Release Note

Docs

knative-prow · 2023-04-04T20:45:42Z

Hi @Rahul-Kumar-prog. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pkg/apis/feature/features.go

config/core/configmaps/features.yaml

Rahul-Kumar-prog · 2023-04-04T23:15:30Z

@pierDipi I did some spelling and feature explaining mistake. but I will take care of it next time.

Other than this everything is fine ?

Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>

pierDipi · 2023-04-05T07:28:47Z

/ok-to-test

pierDipi · 2023-04-05T07:29:33Z

@pierDipi I did some spelling and feature explaining mistake. but I will take care of it next time.

Other than this everything is fine ?

Yes, no worries, thank you!

pierDipi · 2023-04-05T09:57:14Z

For some reason, GH actions are not running 🤔

pierDipi · 2023-04-05T09:57:38Z

Ok, now they are

codecov · 2023-04-05T09:59:55Z

Codecov Report

Patch coverage has no change and project coverage change: -0.06 ⚠️

Comparison is base (f6ca59b) 80.45% compared to head (42276c9) 80.40%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6845      +/-   ##
==========================================
- Coverage   80.45%   80.40%   -0.06%     
==========================================
  Files         236      236              
  Lines       12213    12243      +30     
==========================================
+ Hits         9826     9844      +18     
- Misses       1896     1907      +11     
- Partials      491      492       +1

Impacted Files	Coverage Δ
pkg/apis/feature/features.go	`65.62% <0.00%> (-21.88%)`	⬇️

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

pierDipi · 2023-04-05T10:20:44Z

config/core/configmaps/features.yaml

+  # ALPHA feature: The transport-encryption flag allows you to encrypt events in transit using the transport layer security (TLS) protocol.
+  # For more details: https://github.com/knative/eventing/issues/5957


There is a lint issue at line 49: https://github.com/knative/eventing/actions/runs/4617248930/jobs/8163277093?pr=6845

[trailing whitespace] reported by reviewdog 🐶 transport-encryption: "disabled" Raw Output: config/core/configmaps/features.yaml:49: transport-encryption: "disabled"

ohh that whitespace stoping GH actions ? i keep this thing in my mind. Thankyou so much @pierDipi for helping me.

No worries, we have these automated checks so that they help us

config/core/configmaps/features.yaml

Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>

pierDipi

/lgtm
/approve

knative-prow · 2023-04-05T22:06:07Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi, Rahul-Kumar-prog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [pierDipi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pierDipi · 2023-04-05T22:06:11Z

Thanks @Rahul-Kumar-prog

Fixes knative#6836  ## Proposed Changes  - - - ### Pre-review Checklist  - [ ] **At least 80% unit test coverage** - [ ] **E2E tests** for any new behavior - [ ] **Docs PR** for any user-facing impact - [ ] **Spec PR** for any new API feature - [ ] **Conformance test** for any change to the spec **Release Note**  ```release-note ``` **Docs**  --------- Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>

Add transport-encryption feature flag

334e449

knative-prow bot requested review from creydr and matzew April 4, 2023 20:45

knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 4, 2023

pierDipi reviewed Apr 4, 2023

View reviewed changes

pkg/apis/feature/features.go Outdated Show resolved Hide resolved

pkg/apis/feature/features.go Outdated Show resolved Hide resolved

pkg/apis/feature/features.go Outdated Show resolved Hide resolved

config/core/configmaps/features.yaml Outdated Show resolved Hide resolved

Rahul-Kumar-prog and others added 4 commits April 5, 2023 12:02

Update config/core/configmaps/features.yaml

c30c489

Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>

Update pkg/apis/feature/features.go

ef762c4

Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>

Update pkg/apis/feature/features.go

4b26edc

Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>

Update pkg/apis/feature/features.go

f57081a

Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>

knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 5, 2023

pierDipi closed this Apr 5, 2023

pierDipi reopened this Apr 5, 2023

pierDipi reviewed Apr 5, 2023

View reviewed changes

config/core/configmaps/features.yaml Outdated Show resolved Hide resolved

Update config/core/configmaps/features.yaml

42276c9

Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>

pierDipi approved these changes Apr 5, 2023

View reviewed changes

knative-prow bot assigned pierDipi Apr 5, 2023

knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 5, 2023

knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2023

knative-prow bot merged commit d991040 into knative:main Apr 5, 2023

		# ALPHA feature: The transport-encryption flag allows you to encrypt events in transit using the transport layer security (TLS) protocol.
		# For more details: https://github.com/knative/eventing/issues/5957

Conversation

Rahul-Kumar-prog commented Apr 4, 2023

Proposed Changes

Pre-review Checklist

Uh oh!

knative-prow bot commented Apr 4, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Rahul-Kumar-prog commented Apr 4, 2023

Uh oh!

pierDipi commented Apr 5, 2023

Uh oh!

pierDipi commented Apr 5, 2023

Uh oh!

pierDipi commented Apr 5, 2023

Uh oh!

pierDipi commented Apr 5, 2023

Uh oh!

codecov bot commented Apr 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

pierDipi Apr 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Rahul-Kumar-prog Apr 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pierDipi Apr 5, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pierDipi left a comment

Choose a reason for hiding this comment

Uh oh!

knative-prow bot commented Apr 5, 2023

Uh oh!

pierDipi commented Apr 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Apr 5, 2023 •

edited

Loading

pierDipi Apr 5, 2023 •

edited

Loading

Rahul-Kumar-prog Apr 5, 2023 •

edited

Loading