Eventing TLS: Add Addresses to Addressable and additional Address fields

[vishal-chdhry]

Changes

Addressable and AddressStatus types the Eventing TLS feature track describes

• https://docs.google.com/document/d/1H-x_oji8LqkCyd7tlsSyclmUe7FAmEJPgRxOU_0pkn8/edit?resourcekey=0-lzDIPJsZOP3G17QE_g1lHw#
• 🧹 Update or clean up current behavior

/kind feature
/area API

Fixes #2711

Release Note

Add Addresses to Addressable.
Add Name and CACerts field to Address

Docs

[knative-prow]

@vishal-chdhry: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

Details

In response to this:

Changes

Closes: #2711
Addressable and AddressStatus types the Eventing TLS feature track describes

• https://docs.google.com/document/d/1H-x_oji8LqkCyd7tlsSyclmUe7FAmEJPgRxOU_0pkn8/edit?resourcekey=0-lzDIPJsZOP3G17QE_g1lHw#
• 🧹 Update or clean up current behavior

/kind

Fixes #

Release Note

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[knative-prow]

Welcome @vishal-chdhry! It looks like this is your first PR to knative/pkg 🎉

[knative-prow]

Hi @vishal-chdhry. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pierDipi]

Thanks!

Some suggestions to make the comments clearer and more navigable.
I put my comments on the v1 API but those apply to v1beta1 as well.

[vishal-chdhry]

1. Should I update the public document with these changes as well?
2. And I manually updated the populate method for addressable, is there any other methods that I have to create/update
3. Are there any tests that I should write for addressable_types_test.go

[pierDipi]

1. Should I update the public document with these changes as well?

There is no need, the doc is usually abstract and high level, some details like comments can vary during the implementation.

2. And I manually updated the populate method for addressable, is there any other methods that I have to create/update

I think CI tests will tell us if something is breaking and needs updates

/ok-to-test

3. Are there any tests that I should write for addressable_types_test.go

No, we will add tests covering new fields as part of #2714

[pierDipi]

/lgtm
/approve

[pierDipi]

Thanks @vishal-chdhry

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi, Vishal-Chdhry

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• apis/duck/OWNERS [pierDipi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment