Skip to content

Follow up on unused using cleanup#802

Closed
stan-sz wants to merge 1 commit intokubernetes-client:masterfrom
stan-sz:master
Closed

Follow up on unused using cleanup#802
stan-sz wants to merge 1 commit intokubernetes-client:masterfrom
stan-sz:master

Conversation

@stan-sz
Copy link
Contributor

@stan-sz stan-sz commented Mar 23, 2022

Visual Studio IDE is able to clean up all occurences.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stan-sz
To complete the pull request process, please assign brendandburns after the PR has been reviewed.
You can assign the PR to them by writing /assign @brendandburns in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 23, 2022
@stan-sz
Copy link
Contributor Author

stan-sz commented Mar 23, 2022

/assign tg123

@brendandburns
Copy link
Contributor

Thanks for the PR, but CI/CD is failing. Please fix.

@tg123
Copy link
Member

tg123 commented Mar 24, 2022

/LGTM

see if rebase could fix

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 24, 2022
@k8s-ci-robot
Copy link
Contributor

@stan-sz: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stan-sz
Copy link
Contributor Author

stan-sz commented Mar 24, 2022

It turns out VS IDE has problems with static code analysis. I'll close this PR and see if I can get VS to work with this repo.

@stan-sz stan-sz closed this Mar 24, 2022
@stan-sz
Copy link
Contributor Author

stan-sz commented Mar 24, 2022

See #810

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants