Skip to content

Standardize TargetFramwork for VisualStudio IDE#810

Merged
tg123 merged 5 commits intokubernetes-client:masterfrom
stan-sz:master
Mar 29, 2022
Merged

Standardize TargetFramwork for VisualStudio IDE#810
tg123 merged 5 commits intokubernetes-client:masterfrom
stan-sz:master

Conversation

@stan-sz
Copy link
Contributor

@stan-sz stan-sz commented Mar 24, 2022

net5.0 and net6.0 are the standard target framework monikers in VS. Additionally, use singular <TargetFramework> for a single TFM values.
This allows opening the sln file in VS IDE. Additionally made CRLF->LF changes and test framework upgrade.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 24, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stan-sz
To complete the pull request process, please assign brendandburns after the PR has been reviewed.
You can assign the PR to them by writing /assign @brendandburns in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 24, 2022
@stan-sz
Copy link
Contributor Author

stan-sz commented Mar 24, 2022

/assign tg123

Copy link
Member

@tg123 tg123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

some nits

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2022
Co-authored-by: Boshi Lian <farmer1992@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 28, 2022
@tg123
Copy link
Member

tg123 commented Mar 28, 2022

/LGTM

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 28, 2022
@tg123 tg123 merged commit 9e6e2f0 into kubernetes-client:master Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants