Open
Conversation
Signed-off-by: Anand Joseph <anajoseph@nvidia.com>
kylebgorman
reviewed
Feb 10, 2026
Owner
kylebgorman
left a comment
kylebgorman
left a comment
There was a problem hiding this comment.
one comment even though we're talking offline
Owner
There was a problem hiding this comment.
As a principle of least surprise, I would expect ./build.sh to work when my current directory is third_party, and I would not necessarily expect it to work as third_party/./build.sh, but the opposite is true here.
I would also just call it build using the convention (which I have from Google) that a script with no extension is executable and one with .sh is just a Bash library.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support to build natively on x86_64/aarch64 platforms.