Skip to content

Multi-Platform build #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anand-nv wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −1
Open

Multi-Platform build #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion third_party/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,9 @@
# ******************************************************
# *** All the following images are based on this one ***
# ******************************************************
FROM quay.io/pypa/manylinux_2_28_x86_64 AS common
ARG TARGET_ARCH="x86_64"

FROM quay.io/pypa/manylinux_2_28_${TARGET_ARCH} AS common

# The versions we want in the wheels.
ENV FST_VERSION "1.8.4"
Expand Down
2 changes: 2 additions & 0 deletions third_party/build.sh
View file
Open in desktop
Copy link
Copy Markdown
Owner

@kylebgorman kylebgorman Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a principle of least surprise, I would expect ./build.sh to work when my current directory is third_party, and I would not necessarily expect it to work as third_party/./build.sh, but the opposite is true here.

I would also just call it build using the convention (which I have from Google) that a script with no extension is executable and one with .sh is just a Bash library.

Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
#!/bin/bash
docker build --build-arg "TARGET_ARCH=`uname -m`" --target=run-tests -t build-pynini-wheels -f third_party/Dockerfile .