✨ Add --unix-newline flag to change newline behavior#209
Conversation
kynan
left a comment
kynan
left a comment
There was a problem hiding this comment.
Thanks for contributing this! I think we want to change the flag name and refactor the tests a bit.
|
@owenlamont @varunsh-xilinx FYI, can you please share your opinion here as this is related to #202 and #208 . |
s-weigand
changed the title
|
Once we've settled on the flag name, can you also update the README? |
Co-authored-by: Florian Rathgeber <florian.rathgeber@gmail.com>
🧪 Use different files for test with and without flag 👌 Use same newline convention for stdout with textconv 🧪 Add test for stdout with textconv
Co-authored-by: Florian Rathgeber <florian.rathgeber@gmail.com>
s-weigand
force-pushed
the
force-lf-eol
branch
from
1f66579 to
4fa2256
Compare
s-weigand
changed the title
kynan
left a comment
kynan
left a comment
There was a problem hiding this comment.
Thanks! I think this is looking good now. Even though we weren't able to solve what we originally intended it's probably still a useful feature. And given how much time we spent on it not merging now feel like a waste :)
In #202, I assumed that people on Windows would also be checking out with CRLF endings and commit LF endings so using |
Co-authored-by: Florian Rathgeber <florian.rathgeber@gmail.com>
3 participants
First of all, thanks for the awesome tool it helps a lot in reducing noise.
I recently encountered the same pre-commit hook fight, described in #208
This change adds the CLI flag
--unix-newlineto use the\ndefault newline, the default is to use OS line ending.Fixes #208