Fix #25; Skip empty continuation lines#145
Merged
Slamdunk merged 1 commit intolaminas:2.14.xfrom Mar 15, 2021
Merged
Conversation
9d8382d to
043e977
Compare
Signed-off-by: AdrienClairembault <aclairembault@teclib.com>
043e977 to
fc002f8
Compare
Contributor
|
@AdrienClairembault (for the future): avoid references in commit messages. Especially if you rebase and force push. These create reference noise for every push: better keep ticket, commit, PR references in PR body itself. |
Slamdunk
approved these changes
Mar 12, 2021
Contributor
Contributor
|
Yes I do, but I need to have a chat with @laminas TSC on how to maintain laminas repos, as I already saw myself having different opinion on how releases should be managed. |
Contributor
|
Thanks, @Slamdunk! 🥳 🎉 |
DominicFath
added a commit
to casasoftch/laminas-mail
that referenced
this pull request
Sep 17, 2021
artemii-karkusha
pushed a commit
to artemii-karkusha/laminas-mail
that referenced
this pull request
May 24, 2023
…mpty-continuation-lines Fix laminas#25; Skip empty continuation lines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The fix introduced in zendframework/zend-mail#196 allow a single empty continuation line in the headers.
The following example will be considered as valid:
But not these two:
While the RFC indicate these empty continuation lines are no longer legal, it also recommend that they should just be ignored and not stop the message from being parsed:
With these changes all empty continuation lines will be ignored so that the 3 example above will all be considered as valid and parsed accordingly.