This repository was archived by the owner on Jan 30, 2020. It is now read-only.
Fix #92 : Allow whitespace empty in empty single line header#196
Merged
weierophinney merged 7 commits intozendframework:masterfrom Jun 6, 2018
Merged
Fix #92 : Allow whitespace empty in empty single line header#196weierophinney merged 7 commits intozendframework:masterfrom
weierophinney merged 7 commits intozendframework:masterfrom
Conversation
samsonasik
changed the title
|
Unfortunately this isn't the totally correct fix as far as I can tell. It will work in some cases, but only if there are no more than 1 empty lines. We're seeing examples of headers that contain upwards of 5-10 empty lines. Admittedly, that kind of email is clearly in the wrong in terms of the spec (though it seems a bit of a grey area in places) but there are libraries out there which seem to be able to parse such emails correctly without falling over on an arbitrary limit of empty lines. |
glensc
reviewed
Mar 6, 2018
test/Storage/MessageTest.php
Outdated
| public function testAllowWhitespaceInEmptySingleLineHeader() | ||
| { | ||
| $src = "From: user@example.com\nTo: userpal@example.net\nSubject: This is your reminder\n \n about the football game tonight\nDate: Wed, 20 Oct 2010 20:53:35 -0400\n\nDon't forget to meet us for the tailgate party!\n"; | ||
| $message = new Message(array('raw' => $src)); |
Contributor
There was a problem hiding this comment.
consistency: short array syntax
Contributor
Author
|
@chrisdeeming that probably an edge case that should not be handled ^^ |
weierophinney
added a commit
that referenced
this pull request
Jun 6, 2018
Fix #92 : Allow whitespace empty in empty single line header
weierophinney
added a commit
that referenced
this pull request
Jun 6, 2018
Member
|
Thanks, @samsonasik. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #92