TitleBar Buttons not working in some cases#1373
Merged
pomianowski merged 3 commits intolepoco:mainfrom May 24, 2025
Merged
Conversation
Contributor
|
This doesn't work in the gallery on my end - The screen coordinates seem to incorrectly translate to the visual's. |
Contributor
Author
High-dpi issue or something? If you try something like var screenPointLogical = presentationSource.CompositionTarget.TransformFromDevice.Transform(
new System.Windows.Point(winPoint.X, winPoint.Y));
var localPoint = this.PointFromScreen(screenPointLogical);before translating point from screen coordinates does it work for you? I'm gonna post a gif with the behaviour before and after, since it seemed to be ok in my tests |
pomianowski
approved these changes
May 24, 2025
pomianowski
added a commit
that referenced
this pull request
Jun 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix addresses an issue that occurred when detecting whether the mouse was hovering over one of the TitleBar buttons (such as minimize, maximize, or close) of a window.
The previous method of detecting the mouse position could lead to incorrect results, particularly when the pointer was moved quickly from outside to inside the window.
Pull request type
What is the current behavior?
When creating an instance of a window with a valid parent and displaying it using ShowDialog (I can reproduce this issue only with modal windows), there's sometimes a behavior where you are unable to click any of the titlebar buttons.
The only way to resolve this issue is by first giving focus to the content of the window and then returning focus to the titlebar area, making it difficult to interact with the titlebar buttons.
Issue Number: N/A
What is the new behavior?
Other information
N/A