Skip to content

TitleBar Buttons not working in some cases #1373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pomianowski merged 3 commits into from
May 24, 2025
+38 −0
Merged

TitleBar Buttons not working in some cases #1373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f8f7453
Update User32.cs
Alessio2405 Mar 4, 2025
9a7231c
Update TitleBarButton.cs
Alessio2405 Mar 4, 2025
c28cba6
Update User32.cs
Alessio2405 Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions src/Wpf.Ui/Controls/TitleBar/TitleBarButton.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,4 +232,39 @@ protected void OnButtonTypeChanged(DependencyPropertyChangedEventArgs e)
),
};
}

PresentationSource presentationSource = null;

protected bool IsMouseOverElement(nint lParam)
{
System.Drawing.Point winPoint;
bool gotCursorPos = User32.GetCursorPos(out winPoint);

if (!gotCursorPos)
{
int fallbackX = unchecked((short)((long)lParam & 0xFFFF));
int fallbackY = unchecked((short)(((long)lParam >> 16) & 0xFFFF));
winPoint = new System.Drawing.Point(fallbackX, fallbackY);
}

var screenPoint = new System.Windows.Point(winPoint.X, winPoint.Y);

presentationSource ??= PresentationSource.FromVisual(this);

if (presentationSource?.CompositionTarget != null)
{
screenPoint = presentationSource.CompositionTarget.TransformFromDevice.Transform(screenPoint);
}

var localPoint = this.PointFromScreen(screenPoint);

var hitTestRect =
new System.Windows.Rect(
0,
0,
this.ActualWidth,
this.ActualHeight);

return hitTestRect.Contains(localPoint);
}
}
3 changes: 3 additions & 0 deletions src/Wpf.Ui/Interop/User32.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1450,6 +1450,9 @@ [In] IntPtr lParam
[DllImport(Libraries.User32, SetLastError = true)]
[return: MarshalAs(UnmanagedType.Bool)]
public static extern bool GetCursorPos([Out] out WinDef.POINT lpPoint);
[DllImport(Libraries.User32, SetLastError = true)]
public static extern bool GetCursorPos(out System.Drawing.Point lpPoint);


[DllImport(Libraries.User32)]
public static extern bool UnionRect(out WinDef.RECT rcDst, ref WinDef.RECT rc1, ref WinDef.RECT rc2);
Expand Down