Skip to content

ContentDialog control#502

Merged
pomianowski merged 21 commits intolepoco:developmentfrom
IvanDmitriev1:ContentDialog
Jan 31, 2023
Merged

ContentDialog control#502
pomianowski merged 21 commits intolepoco:developmentfrom
IvanDmitriev1:ContentDialog

Conversation

@IvanDmitriev1
Copy link
Copy Markdown
Contributor

@IvanDmitriev1 IvanDmitriev1 commented Jan 17, 2023

Implements a ContentDialog control almost like in winui 3.

Closes: #394, #350

Pull request type

  • Update
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes

What is the current behavior?

  • Dialog initializes in xaml, properties are not cleared after closing
  • Dialog will not change the size according to the size of the content

What is the new behavior?

  • ContentDialog should be initialized in code
  • ContentDialog resizes according to the size of the content

@github-actions github-actions bot added controls Changes to the appearance or logic of custom controls. styles Topic is related to styles labels Jan 17, 2023
@IvanDmitriev1
Copy link
Copy Markdown
Contributor Author

@pomianowski any feedback about this ?

@pomianowski pomianowski merged commit e31508e into lepoco:development Jan 31, 2023
@IvanDmitriev1 IvanDmitriev1 deleted the ContentDialog branch February 1, 2023 06:36
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

controls Changes to the appearance or logic of custom controls. styles Topic is related to styles

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants