Implement multilevel navigation#512
Merged
pomianowski merged 27 commits intolepoco:developmentfrom Jan 31, 2023
Merged
Conversation
PageTagNavigationViewsDictionary , PageIdNavigationViewsDictionary , PageTypeNavigationViewsDictionary
…aderContent property
Contributor
Author
|
@pomianowski how about not adding |
pomianowski
added
controls
pomianowski
approved these changes
Jan 29, 2023
Member
pomianowski
left a comment
pomianowski
left a comment
There was a problem hiding this comment.
Thank you for the huge amount of work you put into improving the navigation. Looks much better now. Breadcrumb for sub-items and styles can still be improved, but for now it looks great.
| { | ||
| new NavigationViewItem { Content = "BreadcrumbBar", TargetPageType = typeof(BreadcrumbBarPage) }, | ||
| new NavigationViewItem { Content = "NavigationView", TargetPageType = typeof(NavigationViewPage) }, | ||
| new NavigationViewItem { Content = "Multilevel navigation demo", TargetPageType = typeof(MultilevelNavigationPage) }, |
Member
There was a problem hiding this comment.
Kinda long title, maybe just "Multilevel navigation"
Member
|
There are a few bugs left to fix in Wpf.Ui.Demo |
Contributor
Author
|
How about to review a #502 ? |
github-actions
bot
removed
the
controls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleans and simplified
NavigationViewcode.Removed multiple enumerations over
MenuItemsandFooterMenuItems.Pull request type
What is the new behavior?
BreadcrumbBarNavigateWithHierarchyNavigatingevent that supports canceling the current navigationGoBackOther information
GoForwardcurrently is not implemented