Skip to content

Merge development and bump version to 3.0.1#996

Merged
pomianowski merged 66 commits intomainfrom
development
Mar 13, 2024
Merged

Merge development and bump version to 3.0.1#996
pomianowski merged 66 commits intomainfrom
development

Conversation

@pomianowski
Copy link
Copy Markdown
Member

Pull request type

Please check the type of change your PR introduces:

  • Update
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes

LHTXQ and others added 30 commits May 6, 2023 21:51
Fix focus issues with ContentDialog
Update sample to use `ui:FluentWindow`. `ui:UiWindow` does not exist in version 3.*
Change MinWidth = 310 to 40 of main border because it is cut while collapse menu.
Change MinWidth = 310 to 40 of main border because it is cut while collapse menu.
Tilebar FontSize is not able to change it was static now change to TemplateBinding FontSize
add these 3 overload methods with `dataContext` to `INavigationService` so that
```C#
bool Navigate(Type pageType, object dataContext);
bool Navigate(string pageIdOrTargetTag, object dataContext);
bool NavigateWithHierarchy(Type pageType, object dataContext);
```

However, if the current displaying page (ie. top-most navigation stack) is `pageType`, `Navigate*(...)` returns `false` and does nothing.
I managed to force-refresh the stack by doing this in client code:
```C#
while (!NavSvc.NavigateWithHierarchy(typeof(SomePage), someData)
{
    // failed, try pop the stack and try again
    if (!NavSvc.GoBack())
    {
        // cannot pop stack, really failed...
        Log.LogCritical(...);
        break;
    }
}
```
so derived class can use them
UpdateMenuItemsTemplate And AddItemsToDictionaries when MenuItems changed.
Set `IsTabStop=False` in the `ClearButton`, `InlineIncrementButton`, `InlineDecrementButton`, and/or `RevealButton` present in `TextBox`, `AutoSuggestBox`, `NumberBox` and `PasswordBox`.
…een ComboBoxItems

Currently, `ComboBoxItem` and `Border` both have margins equal to `ComboBoxItemMargin`. This gives an effective margin of `2 * ComboBoxItemMargin`.

By removing the `ComboBoxItem` margin and setting `Border`'s margin to `2 * ComboBoxItemMargin` we ensure there's no space between `ComboBoxItem`s that can't be clicked to change the selection.

A downside of this is that the customizability of `ComboBoxItem` is diminished. It is possible to increase the margin but not decrease it under `2 * ComboBoxItemMargin`
Fixed progressbar orientation property.
[NavSvc] make `INavigationService.Navigate*()` accepts `dataContext` as argument
ApplicationManager.ApplySystemTheme UpdateAccent fix
Don't focus on inline buttons or icons in text input controls when pressing Tab
Update NavigationView.Properties.cs
make `NavigationService` throw-helpers `protected` (instead of `private`)
Let TitleBar show 'SystemMenu' on mouse right button up.
Update NavigationViewCompact.xaml
Make TitleBarButton public to enable re-templating TitleBar.
Update NavigationViewLeftMinimalCompact.xaml
Update pipelines and bump version
@pomianowski pomianowski merged commit 65e7bc6 into main Mar 13, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.