Implement support for VPC Dual Stack#706
Merged
lgarber-akamai merged 3 commits intolinode:proj/vpc-dual-stackfrom Apr 10, 2025
Merged
Implement support for VPC Dual Stack#706lgarber-akamai merged 3 commits intolinode:proj/vpc-dual-stackfrom
lgarber-akamai merged 3 commits intolinode:proj/vpc-dual-stackfrom
Conversation
lgarber-akamai
force-pushed
the
new/vpc-dual-stack
branch
from
35c120b to
852edd9
Compare
lgarber-akamai
commented
Apr 1, 2025
Comment on lines
+94
to
102
| type InstanceConfigInterfaceUpdateOptionsIPv6SLAAC struct { | ||
| Range *string `json:"range,omitempty"` | ||
| } | ||
|
|
||
| // InstanceConfigInterfaceUpdateOptionsIPv6Range represents a single IPv6 ranges of a Linode interface | ||
| // specified during updates. | ||
| type InstanceConfigInterfaceUpdateOptionsIPv6Range struct { | ||
| Range *string `json:"range,omitempty"` | ||
| } |
Contributor
Author
There was a problem hiding this comment.
I'm not a fan of the redundancy here but I wanted to make sure we can account for any potential future divergences.
lgarber-akamai
requested review from
jriddle-linode and
ykim-akamai
and removed request for
a team
lgarber-akamai
commented
Apr 1, 2025
Comment on lines
+83
to
+84
|
|
||
| assert.Equal(t, "1234::5678/64", iface.IPv6.SLAAC[0].Range) |
Contributor
Author
There was a problem hiding this comment.
In the future it'd be helpful if we could also assert on the raw request body made by unit test requests
lgarber-akamai
commented
Apr 2, 2025
| // | ||
| // This is primarily used to ensure that the GetCreateOptions() and GetUpdateOptions() | ||
| // functions are implemented correctly. | ||
| func assertJSONObjectsSimilar[TA, TB any](t testing.TB, a TA, b TB) { |
Contributor
Author
There was a problem hiding this comment.
I'm wondering if this would be worth adding in a separate PR against the main branch since it discovered a few null pointer derefs in certain GetCreateOptions(...) and GetUpdateOptions(...) implementations.
Contributor
There was a problem hiding this comment.
These helpers are great addition. Nice work!
jriddle-linode
approved these changes
Apr 8, 2025
Collaborator
jriddle-linode
left a comment
jriddle-linode
left a comment
There was a problem hiding this comment.
works locally and looks good, agree with duplicating the assertion to main
rahulait
pushed a commit
to rahulait/linodego
that referenced
this pull request
Jun 27, 2025
* Implement support for Dual Stack (IPv6) VPCs * Add GetCreateOptions() and GetUpdateOptions() assertions * Fix assertJSONObjectsSimilar
rahulait
pushed a commit
to rahulait/linodego
that referenced
this pull request
Jul 8, 2025
* Implement support for Dual Stack (IPv6) VPCs * Add GetCreateOptions() and GetUpdateOptions() assertions * Fix assertJSONObjectsSimilar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This pull request implements support for endpoints and request/response fields relating to Dual Stack (IPv6) VPCs. Because the API changes for this feature aren't yet available this PR was developed against unit test mocks.
Changes include:
ipv6field under instance config interfaces (both nested and CRUD)ipv6field on VPCs and VPC subnetsipv6_range,ipv6_is_public, andipv6_addressesfields under the VPC IPs endpoints✔️ How to Test
The following test steps assume you have pulled down this PR locally.
Unit Testing
Integration Testing
Not yet available.
Manual Testing
Not yet available.