Conversation
lgarber-akamai
force-pushed
the
proj/vpc-dual-stack
branch
from
b5419c3 to
584c930
Compare
lgarber-akamai
requested review from
yec-akamai and
zliang-akamai
and removed request for
a team
lgarber-akamai
commented
Aug 22, 2025
| @@ -520,7 +520,7 @@ func TestInstance_Disk_Clone(t *testing.T) { | |||
| disk, err := client.CreateInstanceDisk(context.Background(), instance.ID, linodego.InstanceDiskCreateOptions{ | |||
| Label: "go-disk-test-" + randLabel(), | |||
| Filesystem: "ext4", | |||
| Image: "linode/debian10", | |||
| Image: "linode/debian12", | |||
Contributor
Author
There was a problem hiding this comment.
The changes made in this file aren't related to VPC Dual Stack but they were issues preventing me from re-running the instance fixtures.
lgarber-akamai
commented
Aug 22, 2025
| assert.Equal(t, "auto", iface.Public.IPv4.Addresses[0].Address) | ||
| } | ||
|
|
||
| func TestInterface_Update(t *testing.T) { |
Contributor
Author
There was a problem hiding this comment.
TestInterface_Update is redundant with the more granular interface update tests introduced in this PR, so I removed it for now 🙂
lgarber-akamai
commented
Aug 22, 2025
Contributor
Author
There was a problem hiding this comment.
This was a stale fixture file that's not longer referenced in an integration test.
zliang-akamai
approved these changes
Aug 25, 2025
yec-akamai
approved these changes
Aug 25, 2025
* Add missing VPC Dual Stack docs and LA notices * Fix spacing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This pull request merges all changes relevant to the VPC Dual Stack branch into the
mainbranch to stage it for release.Additionally, this PR contains refreshed fixtures for all
TestInstance*,TestIPAddress*,TestNodeBalancer*, andTestVPC*integration tests.✔️ How to Test
The following test steps assume you have pulled down this PR locally and are using a Linode account with access to VPC Dual Stack.
Unit Testing
Integration Testing