Don't delete the stream from state if requestID doesn't match#3667
Merged
Don't delete the stream from state if requestID doesn't match#3667
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3667 +/- ##
=============================================
Coverage 31.70613% 31.70613%
=============================================
Files 156 156
Lines 47259 47259
=============================================
Hits 14984 14984
Misses 31393 31393
Partials 882 882
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug where a previous pipeline of the same streamID can cause a more recent pipeline to fail.
Example logs showing the bug:
RequestID
337983a7had recently started up but the trickle subscribe stopped due to this input stream check, this was because a previous stream with requestIDbe334f7ewas shutting down and removed the stream in thiscleanupControlfunction.