Skip to content

Don't delete the stream from state if requestID doesn't match #3667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mjh1 merged 1 commit into from
Jul 8, 2025
Merged

Don't delete the stream from state if requestID doesn't match #3667

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions server/ai_mediaserver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1111,7 +1111,7 @@
node := params.node
node.LiveMu.Lock()
pub, ok := node.LivePipelines[stream]
if !ok {
if !ok || pub.RequestID != params.liveParams.requestID {

Check warning on line 1114 in server/ai_mediaserver.go

View check run for this annotation

Codecov / codecov/patch

server/ai_mediaserver.go#L1114 

Added line #L1114 was not covered by tests
// already cleaned up
node.LiveMu.Unlock()
return
Expand All @@ -1123,7 +1123,7 @@
}
node.LiveMu.Unlock()

if pub != nil && pub.ControlPub != nil && pub.RequestID == params.liveParams.requestID {
if pub.ControlPub != nil {

Check warning on line 1126 in server/ai_mediaserver.go

View check run for this annotation

Codecov / codecov/patch

server/ai_mediaserver.go#L1126 

Added line #L1126 was not covered by tests
if err := pub.ControlPub.Close(); err != nil {
slog.Info("Error closing trickle publisher", "err", err)
}
Expand Down
Loading