Skip to content

ai/live: updates to WHIP endpoint for stream creation#3673

Merged
ad-astra-video merged 7 commits intomasterfrom
av/update-whip-stream-create
Jul 14, 2025
Merged

ai/live: updates to WHIP endpoint for stream creation#3673
ad-astra-video merged 7 commits intomasterfrom
av/update-whip-stream-create

Conversation

@ad-astra-video
Copy link
Collaborator

@ad-astra-video ad-astra-video commented Jul 11, 2025

What does this pull request do? Explain your changes. (required)

Updates the Gateway WHIP endpoint to setup stream similar to post request from MediaMTX.

Fixes bug in Location url to remove additional /

Question:

Should this always be behind the live ai auth webhook? If yes, is there any docs on how the auth webhook should be structured and what is returned?

Specific updates (required)

  • Fix Location url returned in header by removing extra / before URL path after port
  • add parsing query string to WHIP endpoint on gateway similar to StartLiveVideo

How did you test each of these updates (required)

Built and tested locally

Does this pull request close any open issues?

Checklist:

@ad-astra-video ad-astra-video requested a review from j0sh July 11, 2025 14:35
@github-actions github-actions bot added go Pull requests that update Go code AI Issues and PR related to the AI-video branch. labels Jul 11, 2025
@codecov
Copy link

codecov bot commented Jul 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 31.70696%. Comparing base (45188b5) to head (87b95e8).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
server/ai_mediaserver.go 0.00000% 10 Missing ⚠️
media/whip_server.go 0.00000% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3673         +/-   ##
===================================================
- Coverage   31.71877%   31.70696%   -0.01181%     
===================================================
  Files            156         156                 
  Lines          47278       47283          +5     
===================================================
- Hits           14996       14992          -4     
- Misses         31398       31406          +8     
- Partials         884         885          +1     
Files with missing lines Coverage Δ
media/whip_server.go 0.00000% <0.00000%> (ø)
server/ai_mediaserver.go 4.63054% <0.00000%> (-0.02293%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45188b5...87b95e8. Read the comment docs.

Files with missing lines Coverage Δ
media/whip_server.go 0.00000% <0.00000%> (ø)
server/ai_mediaserver.go 4.63054% <0.00000%> (-0.02293%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ad-astra-video ad-astra-video merged commit 0536e7c into master Jul 14, 2025
18 checks passed
@ad-astra-video ad-astra-video deleted the av/update-whip-stream-create branch July 14, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI Issues and PR related to the AI-video branch. go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants