ai/live: updates to WHIP endpoint for stream creation#3673
Merged
ad-astra-video merged 7 commits intomasterfrom Jul 14, 2025
Merged
ai/live: updates to WHIP endpoint for stream creation#3673ad-astra-video merged 7 commits intomasterfrom
ad-astra-video merged 7 commits intomasterfrom
Conversation
This reverts commit 088333f.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3673 +/- ##
===================================================
- Coverage 31.71877% 31.70696% -0.01181%
===================================================
Files 156 156
Lines 47278 47283 +5
===================================================
- Hits 14996 14992 -4
- Misses 31398 31406 +8
- Partials 884 885 +1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
j0sh
approved these changes
Jul 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Updates the Gateway WHIP endpoint to setup stream similar to post request from MediaMTX.
Fixes bug in Location url to remove additional
/Question:
Should this always be behind the live ai auth webhook? If yes, is there any docs on how the auth webhook should be structured and what is returned?
Specific updates (required)
Locationurl returned in header by removing extra/before URL path after portStartLiveVideoHow did you test each of these updates (required)
Built and tested locally
Does this pull request close any open issues?
Checklist:
makeruns successfully./test.shpass