Skip to content

ai/live: updates to WHIP endpoint for stream creation #3673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ad-astra-video merged 7 commits into from
Jul 14, 2025
Merged

ai/live: updates to WHIP endpoint for stream creation #3673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7e58094
parse pipeline from WHIP POST request
ad-astra-video Jul 9, 2025
fa0d4cb
fix Location header url
ad-astra-video Jul 10, 2025
d8ceba8
add queryparams in whip endpoint as pipeline params
ad-astra-video Jul 10, 2025
088333f
fix startup to allow 0 price on ai models
ad-astra-video Jul 9, 2025
0458dd6
add additional url path query parsing
ad-astra-video Jul 11, 2025
ee0ea00
Revert "fix startup to allow 0 price on ai models"
ad-astra-video Jul 11, 2025
87b95e8
Merge branch 'master' into av/update-whip-stream-create
ad-astra-video Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion media/whip_server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,7 +493,7 @@
if r.TLS != nil {
scheme = "https"
}
return fmt.Sprintf("%s://%s/%s", scheme, r.Host, r.URL.Path)
return fmt.Sprintf("%s://%s%s", scheme, r.Host, r.URL.Path)

Check warning on line 496 in media/whip_server.go

View check run for this annotation

Codecov / codecov/patch

media/whip_server.go#L496 

Added line #L496 was not covered by tests
}

// split h264 nalus
Expand Down
15 changes: 11 additions & 4 deletions server/ai_mediaserver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -890,15 +890,22 @@
}
mediamtxOutputURL := internalOutputHost + streamName + "-out"
mediaMTXOutputAlias := fmt.Sprintf("%s%s-%s-out", internalOutputHost, streamName, requestID)
outputURL := ""
streamID := ""
outputURL := r.URL.Query().Get("rtmpOutput")
streamID := r.URL.Query().Get("streamId")

Check warning on line 894 in server/ai_mediaserver.go

View check run for this annotation

Codecov / codecov/patch

server/ai_mediaserver.go#L893-L894 

Added lines #L893 - L894 were not covered by tests
pipelineID := ""
pipeline := ""
pipeline := r.URL.Query().Get("pipeline")

Check warning on line 896 in server/ai_mediaserver.go

View check run for this annotation

Codecov / codecov/patch

server/ai_mediaserver.go#L896 

Added line #L896 was not covered by tests
pipelineParams := make(map[string]interface{})
sourceTypeStr := "livepeer-whip"
queryParams := r.URL.Query().Encode()
orchestrator := r.URL.Query().Get("orchestrator")

rawParams := r.URL.Query().Get("params")
if rawParams != "" {
if err := json.Unmarshal([]byte(rawParams), &pipelineParams); err != nil {
clog.Errorf(ctx, "Invalid pipeline params: %s", err)
http.Error(w, "Invalid pipeline params", http.StatusBadRequest)
return
}

Check warning on line 907 in server/ai_mediaserver.go

View check run for this annotation

Codecov / codecov/patch

server/ai_mediaserver.go#L901-L907 

Added lines #L901 - L907 were not covered by tests
}
// collect RTMP outputs
var rtmpOutputs []string

Expand Down
Loading