add compile_logp convenience function#607
Conversation
Codecov ReportAttention: Patch coverage is
|
digicosmos86
left a comment
digicosmos86
left a comment
There was a problem hiding this comment.
Looks good! Only a fewminor comments. I haven't had a chance to review the tutorials but I trust you, @AlexanderFengler 😆
| @@ -0,0 +1,36 @@ | |||
| name: Run fast tests | |||
There was a problem hiding this comment.
Did you update these flows or do they come from a recent update?
There was a problem hiding this comment.
They came from a recent update, this is some git weirdness :/.
Seemed harmless enough so I let it pass, but annoying and not exactly sure what happened there.
|
|
||
| def make_distribution( | ||
| rv: str | Type[RandomVariable], | ||
| rv: str | Type[RandomVariable] | RandomVariable | Callable, |
There was a problem hiding this comment.
This argument can be confusing now since it also accepts a callable. Might be a good idea to have a separate simulator_fn argument if someone wants to pass a simulator
| DDM: Type[pm.Distribution] = make_distribution( | ||
| "ddm", | ||
| logp_ddm, | ||
| rv="ddm", |
There was a problem hiding this comment.
does rv always have to be passed now? Is there a way to intelligently figure this out from the model string?
2 participants
adding small convenience function