Conversation
cpaniaguam
added
documentation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 🚀 New features to boost your workflow:
|
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
AlexanderFengler
left a comment
AlexanderFengler
left a comment
There was a problem hiding this comment.
@cpaniaguam don't fully get what's happening with the deletions in the notebooks here.
Let's discuss tomorrow during checkin meeting, I think I just don't grasp fully what the PR accomplishes.
|
@cpaniaguam the other PR drops the meta data, this one looks more like it's dropping all output? Can you clarify? |
AlexanderFengler
left a comment
AlexanderFengler
left a comment
There was a problem hiding this comment.
remaining slightly confused let's talk about this quickly.
cpaniaguam
force-pushed
the
660-ci-exercise-tutorial-notebooks
branch
from
af4ee0e to
a4451aa
Compare
AlexanderFengler
left a comment
AlexanderFengler
left a comment
There was a problem hiding this comment.
left a few questions.
| }, | ||
| { | ||
| "cell_type": "code", | ||
| "execution_count": null, |
There was a problem hiding this comment.
is the idea to drop the execution count again?
docs/tutorials/plotting.ipynb
Outdated
| { | ||
| "cell_type": "code", | ||
| "execution_count": null, | ||
| "execution_count": 1, |
There was a problem hiding this comment.
idea to drop the execution count again, or fine as is?
| @@ -0,0 +1,41 @@ | |||
| name: Check notebooks | |||
|
|
|||
| on: | |||
There was a problem hiding this comment.
do we want this upon every pull_request?
There was a problem hiding this comment.
I think it wouldn't hurt.
There was a problem hiding this comment.
just for the record, we decided to move forward with running this manually and upon building docs upon release.
There was a problem hiding this comment.
Yes. I'll update this shortly.
cpaniaguam
force-pushed
the
660-ci-exercise-tutorial-notebooks
branch
from
e7365a6 to
6520fb0
Compare
|
@AlexanderFengler One of the tutorials has a problem. I documented it in #688. |
Ok we fix that issue before merging this one then correct? |
Not necessarily. I think the two are independent. |
AlexanderFengler
left a comment
AlexanderFengler
left a comment
There was a problem hiding this comment.
ok I think this is good to merge now! Thanks @cpaniaguam.
We can deal with emerging issues on this front and make sure the docs are pristine again for the next release :).
2 participants
This pull request introduces a new GitHub workflow for checking Jupyter notebooks and updates the development dependencies in the
pyproject.tomlfile. The most important changes are:Workflow Enhancements:
Dependency Updates:
pyproject.tomlfile to includenbvalas a development dependency, which is necessary for validating Jupyter notebooks.Note
Currently there are changes (deletions) to notebook outputs and metadata. If there is interest in keeping cell output, the corresponding commit can be reverted and apply #675 instead.