Skip to content

Remove nb metadata but keep output#675

Merged
cpaniaguam merged 8 commits into
mainfrom
remove-nb-cell-metadata
Mar 10, 2025
Merged

Remove nb metadata but keep output#675
cpaniaguam merged 8 commits into
mainfrom
remove-nb-cell-metadata

Conversation

@cpaniaguam
Copy link
Copy Markdown
Collaborator

@cpaniaguam cpaniaguam commented Feb 28, 2025

This is needed for the check_notebooks workflow. Leaving cell output in for docs.

Changes to execution count and metadata cleanup:

@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cpaniaguam cpaniaguam marked this pull request as ready for review February 28, 2025 18:57
Copy link
Copy Markdown
Member

@AlexanderFengler AlexanderFengler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as with the ci workflow pr, need a bit of info to understand what exactly is happening.

Looks good in principle. @cpaniaguam

Copy link
Copy Markdown
Member

@AlexanderFengler AlexanderFengler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Might have to merge main once more to complete this for all new notebooks? @cpaniaguam

@cpaniaguam
Copy link
Copy Markdown
Collaborator Author

@AlexanderFengler I removed the cell metadata in docs/tutorials/tutorial_p_outlier_regression.ipynb but kept its output. We can merge this one now and update #674 with it.

@cpaniaguam cpaniaguam merged commit 136b710 into main Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants