Update to Symfony 4 by pmclain · Pull Request #86 · magento-engcom/php-7.2-support

pmclain · 2018-02-27T16:11:09Z

Description

Updates libraries to versions supporting PHP 7.2. This includes the Symfony components and brings composer.lock to a state that allows composer install on PHP ~7.1.3 and ~7.2.0

Fixed Issues (if relevant)

friendsofphp/php-cs-fixer does not support PHP 7.2 #4

Contribution checklist

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds on Travis CI are green)

allows compoer install on php71 and php72

* Update implementation of `Cm\RedisSession\Handler\ConfigInterface` * Add Redis Sentinel config options to `setup:config:set` command

Replace references of `Symfony\Console\Helper\TableHelper` with `Symfony\Console\Helper\Table`. `new` was used instead of DI to mirror existing reference in https://github.com/magento/magento2/blob/a083717504f63fd22748fb42d74b63c2906226ef/app/code/Magento/Developer/Console/Command/DiInfoCommand.php#L84 Not sure which is preferred.

It is replaced with `Symfony\Console\Helper\QuestionHelper`

`Symfony\Component\Console\Helper\ProgressBar` has been declared Final and cannot be mocked.

The second constructor argument of parent class `Symfony\Component\Console\Output\Output` must be boolean.

buskamuza · 2018-02-28T22:08:00Z

composer.json

-        "magento/composer": "~1.2.0",
+        "colinmollenhour/php-redis-session-abstract": "~1.3.8",
+        "composer/composer": "~1.6.0",
+        "friendsofphp/php-cs-fixer": "~2.10.0",


Why is it moved to require from require-dev?

No reason. Moved back to require-dev.

buskamuza · 2018-02-28T22:08:50Z

composer.json

-        "symfony/console": "~2.3, !=2.7.0",
-        "symfony/event-dispatcher": "~2.1",
-        "symfony/process": "~2.1",
+        "sebastian/phpcpd": "~3.0.0",


Why is it moved to require from require-dev?

No reason. Moved back to require-dev.

buskamuza · 2018-02-28T22:18:24Z

composer.json

    },
    "require": {
-        "php": "7.0.2|7.0.4|~7.0.6|~7.1.0",
+        "php": "~7.1.3||~7.2.0",


Related #30
@pmclain , could you also update the related PR to reflect same PHP versions and target it to the same upgrade-libs branch? I'll merge both then. Or if you have time, merge it into this PR.

I've applied the updates from #30 to this PR. I'll close #30

buskamuza · 2018-02-28T22:22:12Z

composer.json

-        "composer/composer": "1.4.1",
-        "magento/composer": "~1.2.0",
+        "colinmollenhour/php-redis-session-abstract": "~1.3.8",
+        "composer/composer": "~1.6.0",


Please update Magento/Framework/composer.json with the new version.
Same for symfony/console and symfony/process

buskamuza · 2018-02-28T22:39:18Z

Confirmed: composer install runs w/o errors on both PHP 7.1 and 7.2

buskamuza · 2018-02-28T23:06:47Z

Docs needed:

http://devdocs.magento.com/guides/v2.3/architecture/arch-basics.html and related articles

@shrielenee, could you please help with this? See updated PHP versions https://github.com/magento-engcom/php-7.2-support/pull/86/files#diff-b5d0ee8c97c7abd7e3fa29b9a27d1780R15

Update to "~7.1.3||~7.2.0"

Match library versions with those in project composer.json

pmclain · 2018-03-01T02:52:24Z

@buskamuza The requested changes have been made. I also updated .travis.yml, replacing php 7.0 with 7.2.

Fixes magento-engcom#25

buskamuza · 2018-03-06T23:34:37Z

Waiting for PRs to internal repositories before this one can be merged.

buskamuza · 2018-03-07T06:19:33Z

dev/tests/acceptance/tests/functional/Magento/FunctionalTest/AdminNotification/composer.json

    "require": {
        "magento/magento2-functional-testing-framework": "1.0.0",
-        "php": "7.0.2|7.0.4|~7.0.6|~7.1.0"
+        "php": "~7.1.3||~7.2.0"


I just noticed that MFTF tests has been also updated. I think it's better to be done in a separate task.
MFTF tests are run separately from the Magento application, so they can still run on its own supported PHP version. In scope of updating MFTF dependencies we should verify that the framework is not broken, which increases scope for this task.

Sounds good. I'll back those changes out.

buskamuza · 2018-03-07T14:50:27Z

dev/tests/functional/composer.json

    },
    "require": {
-        "php": "7.0.2|~7.0.6|~7.1.0",
+        "php": "~7.1.3||~7.2.0",


I propose to skip this one too for now, and make the update in a separate task.

Patrick McLain added 7 commits February 24, 2018 13:27

Update/remove packages in composer.json

f0f4101

allows compoer install on php71 and php72

Update colinmollenhour/php-redis-session-abstract

0432bc9

* Update implementation of `Cm\RedisSession\Handler\ConfigInterface` * Add Redis Sentinel config options to `setup:config:set` command

Fix reference to removed Diaglog console helper

fc3f13f

It is replaced with `Symfony\Console\Helper\QuestionHelper`

Remove mocking of Final class

06b1f78

`Symfony\Component\Console\Helper\ProgressBar` has been declared Final and cannot be mocked.

Correct default argument type in MultipleStreamOutput

7c4e41b

The second constructor argument of parent class `Symfony\Component\Console\Output\Output` must be boolean.

Correct comparison logic in ConfigSetCommandTest

49a278a

buskamuza self-assigned this Feb 28, 2018

buskamuza reviewed Feb 28, 2018

View reviewed changes

buskamuza added requires-ee-changes requires-updater-changes requires-b2b-changes and removed requires-b2b-changes labels Feb 28, 2018

buskamuza added the requires-docs label Feb 28, 2018

buskamuza mentioned this pull request Feb 28, 2018

Updated composer.json with new library versions #41

Closed

4 tasks

Patrick McLain added 3 commits February 28, 2018 21:06

Move libraries back to require-dev

524f4b8

Update PHP version requirements in all composer.json

e20d5b8

Update to "~7.1.3||~7.2.0"

magento/framework composer.json updates

a64afce

Match library versions with those in project composer.json

pmclain mentioned this pull request Mar 1, 2018

Update PHP version dependency to ~7.2.0 #30

Closed

4 tasks

Replace php 7.0 with 7.2 in .travis.yml

5708643

Fixes magento-engcom#25

pmclain force-pushed the smyfony4 branch from 9bfa672 to 5708643 Compare March 1, 2018 03:10

buskamuza added the requires-b2b-changes label Mar 6, 2018

buskamuza approved these changes Mar 6, 2018

View reviewed changes

buskamuza reviewed Mar 7, 2018

View reviewed changes

buskamuza added this to the Magento 2.3.0 milestone Mar 7, 2018

This was referenced Mar 7, 2018

3rd-party libraries do not support PHP 7.2 #24

Closed

Update PHP version dependency to ~7.2.0 #15

Closed

friendsofphp/php-cs-fixer does not support PHP 7.2 #4

Closed

buskamuza reviewed Mar 7, 2018

View reviewed changes

buskamuza assigned pmclain Mar 8, 2018

joanhe merged commit 5708643 into magento-engcom:libs-upgrade Mar 14, 2018

Conversation

pmclain commented Feb 27, 2018 • edited by buskamuza Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Fixed Issues (if relevant)

Contribution checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

buskamuza commented Feb 28, 2018

Uh oh!

buskamuza commented Feb 28, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pmclain commented Mar 1, 2018

Uh oh!

buskamuza commented Mar 6, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pmclain commented Feb 27, 2018 •

edited by buskamuza

Loading

buskamuza commented Feb 28, 2018 •

edited

Loading