Update `pelago/emogrifier` to version 6.0.0 by anzin · Pull Request #34396 · magento/magento2

anzin · 2021-10-21T08:29:37Z

Description (*)

Updated pelago-emogrifier composer dependencies to be compatible with PHP 8.1.

Related Pull Requests

https://github.com/magento/partners-magento2ee/pull/638

Fixed Issues (if relevant)

Fixes Update pelago/emogrifier to v6.x #34374

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

m2-assistant · 2021-10-21T08:29:40Z

Hi @anzin. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me platform-health instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

anzin · 2021-10-21T08:32:22Z

@magento run all tests

magento-automated-testing · 2021-10-21T08:32:27Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

anzin · 2021-10-21T08:33:21Z

@magento run all tests with env PHP 8.0

magento-automated-testing · 2021-10-21T08:33:25Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

anzin · 2021-10-21T11:49:09Z

@magento run Functional Tests B2B

magento-automated-testing · 2021-10-21T11:49:16Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2021-10-21T18:52:59Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2021-10-21T18:53:05Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2021-10-21T21:30:31Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

composer.json

magento-automated-testing · 2021-10-22T06:54:45Z

Pull Requests are not mergeable to the mainline. Please merge the latest mainlines to your Pull Requests and restart the builds.

magento-automated-testing · 2021-10-22T06:54:51Z

Pull Requests are not mergeable to the mainline. Please merge the latest mainlines to your Pull Requests and restart the builds.

Den4ik · 2021-10-22T08:36:31Z

@magento run all tests with env PHP 8.0

magento-automated-testing · 2021-10-22T08:36:34Z

Pull Requests are not mergeable to the mainline. Please merge the latest mainlines to your Pull Requests and restart the builds.

anzin · 2021-10-22T08:40:59Z

@magento run all tests

magento-automated-testing · 2021-10-22T08:41:07Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

anzin · 2021-10-22T08:41:22Z

@magento run all tests with env PHP 8.0

magento-automated-testing · 2021-10-22T08:41:27Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

anzin · 2021-10-22T09:50:49Z

@magento run Unit Tests

magento-automated-testing · 2021-10-22T09:50:54Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

anzin · 2021-10-22T10:03:02Z

@magento run WebAPI Tests

magento-automated-testing · 2021-10-22T10:03:08Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2021-10-22T11:10:58Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2021-10-22T11:15:34Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2021-10-22T13:23:36Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2021-10-22T13:37:29Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

ihor-sviziev

✔ Approved.

Failing tests look not related to changes from this PR.

m2-assistant · 2021-10-22T15:06:37Z

Hi @anzin, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Oct 21, 2021

magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Oct 21, 2021

m2-community-project bot added the Progress: pending review label Oct 21, 2021

ihor-sviziev self-assigned this Oct 21, 2021

m2-community-project bot added Progress: review and removed Progress: pending review labels Oct 21, 2021

ihor-sviziev added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Project: Platform Health labels Oct 21, 2021

andrewbess changed the title ~~Improvements/update pelago emogrifier to 6.0.0~~ Update pelago/emogrifier to version 6.0.0 Oct 21, 2021

andrewbess self-assigned this Oct 21, 2021

andrewbess approved these changes Oct 21, 2021

View reviewed changes

m2-community-project bot added Progress: ready for testing and removed Progress: review labels Oct 21, 2021

eduard13 self-assigned this Oct 21, 2021

xmav suggested changes Oct 22, 2021

View reviewed changes

composer.json Outdated Show resolved Hide resolved

m2-community-project bot assigned xmav Oct 22, 2021

m2-community-project bot added Progress: needs update and removed Progress: ready for testing labels Oct 22, 2021

anzin added 2 commits October 22, 2021 11:26

Updated constraints for laminas libraries.

54022e1

Updated pelago/emogrifier to 6.0.0

433afd7

anzin force-pushed the improvements/update-pelago-emogrifier-to-6.0.0 branch from 49decc1 to 433afd7 Compare October 22, 2021 08:31

Den4ik self-assigned this Oct 22, 2021

Den4ik self-requested a review October 22, 2021 08:36

anzin requested a review from xmav October 22, 2021 09:13

ihor-sviziev mentioned this pull request Oct 22, 2021

Fix random ProcessManagerTest failures #34408

Closed

5 tasks

ihor-sviziev approved these changes Oct 22, 2021

View reviewed changes

m2-community-project bot added Progress: ready for testing and removed Progress: needs update labels Oct 22, 2021

Den4ik approved these changes Oct 22, 2021

View reviewed changes

magento-devops-reposync-svc merged commit 433afd7 into magento:platform-health Oct 22, 2021

This was referenced Oct 22, 2021

Updated constraints for laminas libraries. #34381

Closed

Update constrains for laminas libraries in composer.json #34356

Closed

Conversation

anzin commented Oct 21, 2021

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Oct 21, 2021

Uh oh!

anzin commented Oct 21, 2021

Uh oh!

magento-automated-testing bot commented Oct 21, 2021

Uh oh!

anzin commented Oct 21, 2021

Uh oh!

magento-automated-testing bot commented Oct 21, 2021

Uh oh!

anzin commented Oct 21, 2021

Uh oh!

magento-automated-testing bot commented Oct 21, 2021

Uh oh!

magento-automated-testing bot commented Oct 21, 2021

Uh oh!

magento-automated-testing bot commented Oct 21, 2021

Uh oh!

magento-automated-testing bot commented Oct 21, 2021

Uh oh!

Uh oh!

magento-automated-testing bot commented Oct 22, 2021

Uh oh!

magento-automated-testing bot commented Oct 22, 2021

Uh oh!

Den4ik commented Oct 22, 2021

Uh oh!

magento-automated-testing bot commented Oct 22, 2021

Uh oh!

anzin commented Oct 22, 2021

Uh oh!

magento-automated-testing bot commented Oct 22, 2021

Uh oh!

anzin commented Oct 22, 2021

Uh oh!

magento-automated-testing bot commented Oct 22, 2021

Uh oh!

anzin commented Oct 22, 2021

Uh oh!

magento-automated-testing bot commented Oct 22, 2021

Uh oh!

anzin commented Oct 22, 2021

Uh oh!

magento-automated-testing bot commented Oct 22, 2021

Uh oh!

magento-automated-testing bot commented Oct 22, 2021

Uh oh!

magento-automated-testing bot commented Oct 22, 2021

Uh oh!

magento-automated-testing bot commented Oct 22, 2021

Uh oh!

magento-automated-testing bot commented Oct 22, 2021

Uh oh!

ihor-sviziev left a comment

Choose a reason for hiding this comment

Uh oh!

m2-assistant bot commented Oct 22, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants