Skip to content

Conversation

@proux01
Copy link
Collaborator

@proux01 proux01 commented Mar 28, 2023

Motivation for this change
Things done/to do
  • added corresponding entries in CHANGELOG_UNRELEASED.md
    (do not edit former entries, only append new ones, be careful:
    merge and rebase have a tendency to mess up CHANGELOG_UNRELEASED.md)
  • added corresponding documentation in the headers
Automatic note to reviewers

Read this Checklist and put a milestone if possible.

@affeldt-aist
Copy link
Member

affeldt-aist commented Mar 28, 2023

Note that sqrte is also defined in PR #790 @hoheinzollern

@affeldt-aist affeldt-aist self-requested a review March 29, 2023 07:27
Copy link
Member

@affeldt-aist affeldt-aist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be happy to have it in master.
(I just suggested small shortenings.)

Co-authored-by: Reynald Affeldt <[email protected]>
@proux01
Copy link
Collaborator Author

proux01 commented Apr 6, 2023

Sorry, I should have undrafted that long ago.

@proux01 proux01 marked this pull request as ready for review April 6, 2023 11:42
@affeldt-aist affeldt-aist merged commit 9e026f3 into math-comp:master Apr 7, 2023
@proux01 proux01 deleted the sqrte branch April 7, 2023 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants