Skip to content

Conversation

@affeldt-aist
Copy link
Member

@affeldt-aist affeldt-aist commented Apr 6, 2023

Motivation for this change

generalize power_pos to extended real numbers

taken from PR #790

waiting for PR #887 to prove powere12_sqrt

fixes #883

@hoheinzollern @t6s @proux01

Things done/to do
  • added corresponding entries in CHANGELOG_UNRELEASED.md
    (only append to minimize problems when merging/rebasing)
    (you can consider the use of etc/changes.sh to generate the changelog)
  • added corresponding documentation in the headers
Compatibility with MathComp 2.0
  • I added the label TODO: HB port to make sure someone ports this PR to
    the hierarchy-builder branch or I already opened an issue or PR (please cross reference).
Automatic note to reviewers

Read this Checklist and put a milestone if possible.

@affeldt-aist affeldt-aist added this to the 0.6.2 milestone Apr 6, 2023
@affeldt-aist affeldt-aist marked this pull request as ready for review April 7, 2023 05:50
@affeldt-aist affeldt-aist requested a review from proux01 April 7, 2023 05:51
Copy link
Collaborator

@proux01 proux01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm pushing a commit with the few details and merging.

@proux01 proux01 force-pushed the powere_pos branch 2 times, most recently from 279086e to d776a48 Compare April 9, 2023 08:16
- fixes issue math-comp#883

Co-authored-by: Alessandro Bruni <[email protected]>
Co-authored-by: Takafumi Saikawa <[email protected]>
@affeldt-aist affeldt-aist added the TODO: MC2 port This PR must be ported to mathcomp 2 now that the. Remove this label when the port is done. label Apr 10, 2023
@proux01 proux01 merged commit 59a94ca into math-comp:master Apr 10, 2023
@proux01 proux01 removed the TODO: MC2 port This PR must be ported to mathcomp 2 now that the. Remove this label when the port is done. label Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

duplicate of eq_measurable_fun ?

2 participants