Skip to content

Add server flags for pod probe overrides#1112

Merged
gabrieljackson merged 1 commit intomasterfrom
probe-overrides
Jun 4, 2025
Merged

Add server flags for pod probe overrides#1112
gabrieljackson merged 1 commit intomasterfrom
probe-overrides

Conversation

@gabrieljackson
Copy link
Copy Markdown
Contributor

New server flags have been added which allow for setting new probe override values for the liveness and readiness probes of Mattermost containers. These values are passed on to the custom resource for each installation to modify the deployment.

Values are only changed when a flag is set and only for the specific value of the specific probe. The Operator defaults are used for everything else.

Pods will pick up new override values when they are next updated.

Example with defaults:

    Liveness:   http-get http://:8065/api/v4/system/ping delay=10s timeout=1s period=10s #success=1 #failure=3
    Readiness:  http-get http://:8065/api/v4/system/ping delay=10s timeout=1s period=5s #success=1 #failure=6

Example with two Overrides:

    Liveness:   http-get http://:8065/api/v4/system/ping delay=10s timeout=1s period=12s #success=1 #failure=3
    Readiness:  http-get http://:8065/api/v4/system/ping delay=10s timeout=1s period=5s #success=1 #failure=9

Fixes https://mattermost.atlassian.net/browse/CLD-9199 and https://mattermost.atlassian.net/browse/CLD-9246

Add server flags for pod probe overrides

New server flags have been added which allow for setting new probe
override values for the liveness and readiness probes of Mattermost
containers. These values are passed on to the custom resource for
each installation to modify the deployment.

Values are only changed when a flag is set and only for the specific
value of the specific probe. The Operator defaults are used for
everything else.
@gabrieljackson gabrieljackson added 2: Dev Review Requires review by a developer 2: Infra Review Requires review by a SRE kind/feature Categorizes issue or PR as related to a new feature. labels Jun 2, 2025
@mm-cloud-bot mm-cloud-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 2, 2025
@gabrieljackson gabrieljackson marked this pull request as ready for review June 2, 2025 20:08
@gabrieljackson gabrieljackson added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a developer 2: Infra Review Requires review by a SRE labels Jun 4, 2025
@gabrieljackson gabrieljackson merged commit b3619e1 into master Jun 4, 2025
5 checks passed
@gabrieljackson gabrieljackson deleted the probe-overrides branch June 4, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4: Reviews Complete All reviewers have approved the pull request kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants