Add probe overrides to installation level#1115
Conversation
mm-cloud-bot
added
the
release-note
| secrets, err := k8sClient.Clientset.CoreV1().Secrets(clusterInstallation.Namespace).List(context.Background(), metav1.ListOptions{ | ||
| LabelSelector: k8sCustomSecretKey, | ||
| }) |
There was a problem hiding this comment.
What's going on here?
There was a problem hiding this comment.
Sorry I had noticed this in 1:1 but forgot to remove it. Fixed
gabrieljackson
left a comment
gabrieljackson
left a comment
There was a problem hiding this comment.
LGTM, I think you just need to retry the build workflow.
…er than fully overwriting them
|
@gabrieljackson @andrleite re-requesting review as I have tweaked the logic. Originally it was implemented so that installation overrides would completely overwrite anything server, so if I were to say only override the liveness probe delay, all other fields would fall back on the operator defaults rather than the provisioner server-level ones. Now, it will merge the installation overrides with the server ones (and then fall back on operator defualts). I think this is better for devex (for me :)) as I won't have to mirror all of the server-level overrides (plus my likely singular adjustment) |
|
@claude the postgres test CI pipelines is failing. Run the tests, identify the issue, and fix it. |
|
Claude finished @nickmisasi's task in 6m 32s —— View job ✅ Fixed Postgres Test Failures - Complete!Todo List:
🎯 Root Cause Identified & FixedThe Problem: Inconsistent JSON column handling for the new PodProbeOverrides feature
✅ Solution ImplementedFixed PodProbeOverrides to follow PgBouncerConfig pattern:
📝 Changes CommittedCommit: Files Modified:
What Was Fixed:
🚀 ResultThe postgres test CI pipeline should now pass! The PodProbeOverrides feature will work correctly with proper JSON column handling that matches the existing codebase patterns. |
- Remove manual JSON marshaling/unmarshaling for PodProbeOverrides - Use direct struct mapping like PgBouncerConfig pattern - Update SQL query to select column directly without alias - Remove PodProbeOverridesRaw field from rawInstallation struct - Update createInstallation and updateInstallation methods This aligns with how other JSON columns are handled and fixes the postgres test CI pipeline failures. Co-authored-by: nickmisasi <nickmisasi@users.noreply.github.com> 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
4 participants
Summary
Extends #1112 to allow for Pod Probe Overrides at the installation level, rather than only working server-wide. This is primarily in an effort to support the new Cloud Preview environments (which take longer to spin up because of database load) but could be useful elsewhere.
Ticket Link
Release Note