Fix struct serialization in db to prevent errors with complex structs#1117
Merged
nickmisasi merged 2 commits intomasterfrom Jun 16, 2025
Merged
Fix struct serialization in db to prevent errors with complex structs#1117nickmisasi merged 2 commits intomasterfrom
nickmisasi merged 2 commits intomasterfrom
Conversation
mm-cloud-bot
added
the
release-note-none
stafot
approved these changes
Jun 16, 2025
gabrieljackson
approved these changes
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#1115 has an issue where it works for setting liveness xor readiness, but does not work if you set both. This PR adds proper serialization for the PodProbeOverrides type so that the sql package knows how to handle the complex type properly.
Ticket Link
Release Note