[ci] place all CI helpers under the .ci folder and use - instead of _ in their names#6581
[ci] place all CI helpers under the .ci folder and use - instead of _ in their names#6581
Conversation
borchero
left a comment
There was a problem hiding this comment.
What's the benefit of this change? 😄
|
@borchero Simplification of the repo's structure. All helper scripts used in our CI are placed in one directory. Newcomers won't struggle deducing the difference between |
|
@StrikerRUS ok, I only briefly looked at the file changes before and it seemed like it would only include renames from snake case to kebab case. I see that it actually moves three files 😄 I guess (1) moving files makes a lot of sense, I'm not too sure about (2) changing the file names but I don't really mind. |
jameslamb
left a comment
There was a problem hiding this comment.
I support the idea of removing helpers/ and just consolidating everything into ci/. That will definitely reduce a bit of friction.
I also support preferring - to _, as it requires one less keypress (it's a minor thing, but still nice!).
However.... I think we should keep build_r.R using snake_case. As you noted, it sort of is "public". It's the documented, preferred entry point for building custom variations of the R package (like with GPU support). I don't support breaking peoples' builds in exchange for a bit more consistency in the naming of scripts.
Reverted in d0dbc63. |
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. |
Simplify repo's structure in the following way:
.cifolder-instead of_in scripts' names to ensure their correct orderingbreakingtag due to "public"build-r.Rscript.