Add naming conventions for instruments#4368
Merged
bors[bot] merged 4 commits intomicrosoft:masterfrom Jul 7, 2022
Merged
Conversation
astafan8
approved these changes
Jul 6, 2022
docs/examples/writing_drivers/Creating-Instrument-Drivers.ipynb
Outdated
Show resolved
Hide resolved
docs/examples/writing_drivers/Creating-Instrument-Drivers.ipynb
Outdated
Show resolved
Hide resolved
docs/examples/writing_drivers/Creating-Instrument-Drivers.ipynb
Outdated
Show resolved
Hide resolved
docs/examples/writing_drivers/Creating-Instrument-Drivers.ipynb
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #4368 +/- ##
==========================================
+ Coverage 67.35% 68.35% +0.99%
==========================================
Files 275 275
Lines 30965 31014 +49
==========================================
+ Hits 20857 21199 +342
+ Misses 10108 9815 -293 |
Co-authored-by: Mikhail Astafev <astafan8@gmail.com>
Collaborator
Author
|
@trevormorgan since we are using bors we don't need to merge master back into the branch |
Collaborator
Author
|
bors merge |
Contributor
bors bot
added a commit
that referenced
this pull request
Aug 1, 2022
4371: Update agilent drivers to conform to docs standard r=jenshnielsen a=jenshnielsen Updates to implement #4368 for Agilent. Closes #4365 `@mgunyho` Could you test the new driver. I have updated the name of the variable and gotten rid of the not needed deg2rad converters and replaced them with numpy I also suggest that we get rid of the autogenerated docs for the instruments and replace them with something like this. I would like to add autodocsumm for these modules but am facing the same issue as in #4273 Co-authored-by: Jens H. Nielsen <Jens.Nielsen@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Triggered by #4365 let's define some standard naming conventions to avoid confusion in the future.