Update agilent drivers to conform to docs standard#4371
Merged
bors[bot] merged 11 commits intomicrosoft:masterfrom Aug 1, 2022
Merged
Update agilent drivers to conform to docs standard#4371bors[bot] merged 11 commits intomicrosoft:masterfrom
bors[bot] merged 11 commits intomicrosoft:masterfrom
Conversation
astafan8
reviewed
Jul 7, 2022
Codecov Report
@@ Coverage Diff @@
## master #4371 +/- ##
==========================================
- Coverage 68.38% 68.36% -0.02%
==========================================
Files 283 276 -7
Lines 31043 31024 -19
==========================================
- Hits 21229 21210 -19
Misses 9814 9814 |
jenshnielsen
force-pushed
the
driver/agilent_cleanup
branch
from
05f5a6b to
f3e3704
Compare
This was referenced Jul 25, 2022
jenshnielsen
force-pushed
the
driver/agilent_cleanup
branch
2 times, most recently
from
c61340e to
dea02a6
Compare
astafan8
approved these changes
Jul 26, 2022
Collaborator
Author
jenshnielsen
force-pushed
the
driver/agilent_cleanup
branch
from
dea02a6 to
2bd6d6e
Compare
Deprecate and give better name for output param
…ake str as well as number types
jenshnielsen
force-pushed
the
driver/agilent_cleanup
branch
from
2bd6d6e to
afe0f4a
Compare
Contributor
|
I tested with an E8257D unit that the new driver works, I tried |
Collaborator
Author
|
@mgunyho Thanks bors merge |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to implement #4368 for Agilent. Closes #4365
@mgunyho Could you test the new driver. I have updated the name of the variable and gotten rid of the not needed deg2rad converters and replaced them with numpy
I also suggest that we get rid of the autogenerated docs for the instruments and replace them with something like this.
I would like to add autodocsumm for these modules but am facing the same issue as in #4273