Correct CsWinRTWindowsMetadata#2015
Merged
j0shuams merged 5 commits intomicrosoft:mainfrom Jan 27, 2022
Merged
Conversation
ghost
added
the
Contributor
Author
|
FYI @manodasanW |
manodasanW
reviewed
Jan 25, 2022
manodasanW
approved these changes
Jan 25, 2022
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kythant
reviewed
Jan 26, 2022
kythant
approved these changes
Jan 27, 2022
This was referenced Mar 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a mistake with this PR that used the CsWinRTDependencyWindowsSdkPackagePackageVersion for the Windows metadata used by CsWinRT.
Instead, it should be used for WindowsSdkPackageVersion.
Further, CsWinRTDependencyWindowsSdkPackagePackageVersion should include just the patch version, as the Windows version can vary. This means instead of taking "10.0.18362.23-preview" from Maestro, just take "23-preview".