Update to CsWinRT 1.5.0-prerelease#2016
Merged
j0shuams merged 2 commits intomicrosoft:mainfrom Jan 28, 2022
Merged
Conversation
ghost
added
the
manodasanW
approved these changes
Jan 25, 2022
Member
|
We should rebase this branch once we merge the other PR. |
j0shuams
changed the title
Member
|
Any build warnings or errors from this? Currently I see this multiples of this pair of warnings for dev\Projections* Will this PR fix that? |
DrusTheAxe
approved these changes
Jan 25, 2022
Member
That should be fixed in this version of CsWinRT. |
kythant
approved these changes
Jan 27, 2022
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C#/WinRT started using Maestro to distribute updates automatically, and given this was our first time there were some bumps in the road. We have addressed these and should have less manual work to do next time. For now, I propose we use this PR instead of the one here: #2010
The linked PR has incorrect version updates. Also, this PR needs to be merged AFTER the one here: #2015
This is because PR #2015 changes how one of the variables is used -- the variable is
CsWinRTDependencyWindowsSdkPackagePackageVersion.You'll notice the variable doesn't store a full Windows version, instead it holds the last number used in the Windows SDK package version. This is the number that tells which CsWinRT generated projection to use.