Fix URFW auto-init reference to EnsureIsLoaded()#2501
Merged
DrusTheAxe merged 1 commit intomainfrom May 12, 2022
Merged
Conversation
DrusTheAxe
added
bug
DrusTheAxe
requested review from
BenJKuhn,
MikeHillberg,
Scottj1s,
kythant and
sachintaMSFT
ghost
added
the
BenJKuhn
approved these changes
May 12, 2022
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sachintaMSFT
pushed a commit
that referenced
this pull request
May 12, 2022
sachintaMSFT
added a commit
that referenced
this pull request
May 12, 2022
…elf-contained (#2502) * Fix UndockedRegFreeWinRT auto-initializer issues (#2476) * Fix bad filename * No precompiledheaders when compiling the auto-initializer * Some refinements on the UndockedRegFreeWinRT self-contained and auto-initialization support (#2493) * UrfwInitialize() didn't report if ExtRoLoadCatalog() errored and returned a failing HRESULT (only trapped thrown exceptions, but the implementation does both) (#2498) * Remove C# auto-initialization check for reflection (#2500) * Remove the 'if (Assembly.GetEntryAssembly() != Assembly.GetExecutingAssembly()) { return; }' shortcircuit as it catches loading for reflection AND for common test cases e.g. 'te.exe foo.dll' as auto-initialization isn't restricted to exes (i.e. it gets compiled into foo.dll) and then Entry!=Executing. Revert this for now and restore later when #2456 is addressed (by restrcting auto-init to only compile into exes) * Fix typo * Fix URFW auto-init reference to EnsureIsLoaded() (#2501) Co-authored-by: Howard Kapustein <howardk@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
URFW auto-initializers were incorrectly referencing
UndockedRegFreeWinRT_EnsureIsLoaded()when it should have beenWindowsAppRuntime_EnsureIsLoaded(). This was usually harmless to the C++ auto-init but fatal to C# :-(