Skip to content

Fix issues in UndockedRegFreeWinRT auto-initializer and support for Self-contained#2502

Merged
sachintaMSFT merged 5 commits intorelease/1.1-stablefrom
user/sachinta/UrfwSupportForSelfContainedAndAutoInitialization-on-release-1.1-stable
May 12, 2022
Merged

Fix issues in UndockedRegFreeWinRT auto-initializer and support for Self-contained#2502
sachintaMSFT merged 5 commits intorelease/1.1-stablefrom
user/sachinta/UrfwSupportForSelfContainedAndAutoInitialization-on-release-1.1-stable

Conversation

@sachintaMSFT
Copy link
Copy Markdown
Contributor

@sachintaMSFT sachintaMSFT commented May 12, 2022

Cherry-picking all fixes by @DrusTheAxe to get UndockedRegFreeWinRT auto-initializer and support for self-contained working, into 1.1-stable.

* Fix bad filename

* No precompiledheaders when compiling the auto-initializer
…rned a failing HRESULT (only trapped thrown exceptions, but the implementation does both) (#2498)
* Remove the 'if (Assembly.GetEntryAssembly() != Assembly.GetExecutingAssembly()) { return; }' shortcircuit as it catches loading for reflection AND for common test cases e.g. 'te.exe foo.dll' as auto-initialization isn't restricted to exes (i.e. it gets compiled into foo.dll) and then Entry!=Executing. Revert this for now and restore later when #2456 is addressed (by restrcting auto-init to only compile into exes)

* Fix typo
@ghost ghost added the needs-triage label May 12, 2022
@sachintaMSFT
Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@sachintaMSFT sachintaMSFT changed the title User/sachinta/urfw support for self contained and auto initialization on release 1.1 stable Fix issues in UndockedRegFreeWinRT auto-initializer and support for Self-contained May 12, 2022
@sachintaMSFT sachintaMSFT merged commit 0e0a545 into release/1.1-stable May 12, 2022
@sachintaMSFT sachintaMSFT deleted the user/sachinta/UrfwSupportForSelfContainedAndAutoInitialization-on-release-1.1-stable branch May 12, 2022 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants