fix(List): reduce number of rendered DOM nodes#1218
Conversation
layershifter
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1218 +/- ##
==========================================
+ Coverage 82.56% 82.57% +0.01%
==========================================
Files 752 752
Lines 8859 8868 +9
Branches 1178 1186 +8
==========================================
+ Hits 7314 7323 +9
Misses 1530 1530
Partials 15 15
Continue to review full report at Codecov.
|
layershifter
changed the title
bmdalex
left a comment
bmdalex
left a comment
There was a problem hiding this comment.
good stuff 👍 definitely an improvement
CHANGELOG.md
Outdated
| - Fix routing for accessibility documentation @sophieH29 ([#1208](https://github.com/stardust-ui/react/pull/1208)) | ||
| - Fix `content` prop type in `Dialog` @layershifter ([#1212](https://github.com/stardust-ui/react/pull/1212)) | ||
| - Add `keyboard` up & down key controls for the `Tree` component @priyankar205 ([#1219]https://github.com/stardust-ui/react/pull/1219) | ||
| - Add `keyboard` up & down key controls for the `Tree` component @priyankar205 [#1219](https://github.com/stardust-ui/react/pull/1219) |
There was a problem hiding this comment.
You are still missing one pair of parentheses 🤣
| {contentMediaElement} | ||
| </Flex> | ||
| <Flex column={hasBothParts} className={ListItem.slotClassNames.main} styles={styles.main}> | ||
| {this.wrapWithFlex(headerPart, hasBothParts)} |
There was a problem hiding this comment.
Sorry for commenting after this was merged. Why we have confition for adding Flex if the content and header parts exists, when the Flex we are using are adding gap between the element + mediaElement. With this we have regression (the gap between header + headerMedia and content + contentMedia are incorrect if the header and content are not applied both..).
Previous:
Current:
4 participants
Fixes #1029.
With these changes we will render
Flexand correspondingdivonly when we will really need them.