Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

fix(List): apply gaps on ListItem.main#1222

Merged
layershifter merged 1 commit intomasterfrom
fix/list-gap
Apr 15, 2019
Merged

fix(List): apply gaps on ListItem.main#1222
layershifter merged 1 commit intomasterfrom
fix/list-gap

Conversation

@layershifter
Copy link
Member

Fixes a small regression introduced in #1218, see #1218 (comment)

Before

image

After

image

@layershifter layershifter changed the title fix(List): apply gaps of ListItem.main fix(List): apply gaps on ListItem.main Apr 15, 2019
@DustyTheBot
Copy link
Collaborator

Warnings
⚠️ There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

Generated by 🚫 dangerJS

@codecov
Copy link

codecov bot commented Apr 15, 2019

Codecov Report

Merging #1222 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1222      +/-   ##
==========================================
+ Coverage   82.53%   82.53%   +<.01%     
==========================================
  Files         751      751              
  Lines        8880     8881       +1     
  Branches     1259     1260       +1     
==========================================
+ Hits         7329     7330       +1     
  Misses       1536     1536              
  Partials       15       15
Impacted Files Coverage Δ
packages/react/src/components/List/ListItem.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f69933...ae8a75c. Read the comment docs.

@layershifter layershifter added 🧰 fix Introduces fix for broken behavior. 🚀 ready for review labels Apr 15, 2019
@layershifter layershifter merged commit e5affb1 into master Apr 15, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix/list-gap branch April 15, 2019 12:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

🧰 fix Introduces fix for broken behavior. 🚀 ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants