Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

fix(docs): Set maximum width for examples #1319

Merged
miroslavstastny merged 3 commits into from
May 10, 2019
Merged

fix(docs): Set maximum width for examples #1319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5e132f8
fix(docs): Set maximum width for examples
miroslavstastny May 10, 2019
1701a93
Merge remote-tracking branch 'origin/master' into fix/docs-example-width
miroslavstastny May 10, 2019
267c71f
changelog
miroslavstastny May 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,17 @@
This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]

### BREAKING CHANGES
- Rename `context` prop to `mountNode` in `PortalInner` @layershifter ([#1288](https://github.com/stardust-ui/react/pull/1288))
- Updated Teams' theme color palette values, removed color related site variables @mnajdova ([#1069](https://github.com/stardust-ui/react/pull/1069))
- Remove `defaultTarget` prop in `Popup` component @layershifter ([#1153](https://github.com/stardust-ui/react/pull/1153))
- Add focus border styling mechanism @Bugaa92 in Teams theme ([#1269](https://github.com/stardust-ui/react/pull/1269))

### Fixes
- Fix double rendering of `Popup` component @layershifter ([#1153](https://github.com/stardust-ui/react/pull/1153))
- Docs: fix(docs): Set maximum width for examples @miroslavstastny ([#1319](https://github.com/stardust-ui/react/pull/1319))

### Features
- Add default child a11y behavior to `Menu` related behaviors @silviuavram ([#1282](https://github.com/stardust-ui/react/pull/1282))
- `Ref` component extracted to a `@stardust-ui/react-component-ref` @layershifter ([#1281](https://github.com/stardust-ui/react/pull/1281))
Expand All @@ -32,9 +37,6 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
- Added default and brand color schemes in Teams' theme @mnajdova ([#1069](https://github.com/stardust-ui/react/pull/1069))
- Export `files-upload` SVG icon for `Teams` theme @manindr ([#1293](https://github.com/stardust-ui/react/pull/1293))

### Fixes
- Fix double rendering of `Popup` component @layershifter ([#1153](https://github.com/stardust-ui/react/pull/1153))

<!--------------------------------[ v0.29.1 ]------------------------------- -->
## [v0.29.1](https://github.com/stardust-ui/react/tree/v0.29.1) (2019-05-01)
[Compare changes](https://github.com/stardust-ui/react/compare/v0.29.0...v0.29.1)
Expand Down
3 changes: 2 additions & 1 deletion docs/src/components/ComponentDoc/ExampleSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,13 @@ export type ExampleSectionProps = Extendable<{
title: string
}>

// minmax = prevent example overflow - https://stackoverflow.com/a/43312314
const ExampleSection: React.FC<ExampleSectionProps> = ({ title, children }) => (
<>
<Header as="h2" styles={headerStyle} className="no-anchor">
{title}
</Header>
<Grid variables={{ gridGap: '2rem' }} columns="1">
<Grid variables={{ gridGap: '2rem' }} columns="minmax(550px, 1fr)">
{children}
</Grid>
</>
Expand Down
2 changes: 1 addition & 1 deletion docs/src/examples/components/Text/States/TextExampleTruncated.shorthand.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const [notTruncatedText, truncatedText] = [
)

const TextExampleTruncatedShorthand = () => (
<div style={{ overflow: 'hidden', textOverflow: 'ellipsis', width: 500 }}>
<div style={{ overflow: 'hidden', textOverflow: 'ellipsis' }}>
Copy link
Member Author

@miroslavstastny miroslavstastny May 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted suboptimal fix from #1019

<Text content={notTruncatedText} />
<br />
<br />
Expand Down
2 changes: 1 addition & 1 deletion docs/src/examples/components/Text/States/TextExampleTruncated.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const [notTruncatedText, truncatedText] = [
)

const TextExampleTruncated = () => (
<div style={{ overflow: 'hidden', textOverflow: 'ellipsis', width: 500 }}>
<div style={{ overflow: 'hidden', textOverflow: 'ellipsis' }}>
<Text>{notTruncatedText}</Text>
<br />
<br />
Expand Down