Conversation
mnajdova
requested review from
dvdzkwsk,
kuzhelov,
levithomason and
miroslavstastny
as code owners
Codecov Report
@@ Coverage Diff @@
## master #133 +/- ##
=========================================
Coverage ? 89.04%
=========================================
Files ? 47
Lines ? 776
Branches ? 101
=========================================
Hits ? 691
Misses ? 83
Partials ? 2
Continue to review full report at Codecov.
|
src/lib/customPropTypes.tsx
Outdated
| return error | ||
| } | ||
|
|
||
| export type ItemShorthandType = React.ReactNode | object | (React.ReactNode | object)[] |
There was a problem hiding this comment.
Let's not mix TypeScript typings and PropTypes. They both shared the name "type" but they are entirely different.
Propose we keep typings in /types.
| variables: { height, width, defaultColumnCount, gridGap, padding }, | ||
| }: { | ||
| props: IProps | ||
| props: IGridProps |
There was a problem hiding this comment.
I also think we should hold off on typing styles until we figure out how we're going to do that. Probably warrants a separate PR, some testing, and discussion.
levithomason
left a comment
levithomason
left a comment
There was a problem hiding this comment.
Approving with change requests, see comments.
levithomason
added
needs author feedback
-removing interfaces from styles for now
-removing interfaces from styles for now
| // Props | ||
| // ======================================================== | ||
|
|
||
| export type ItemShorthand = React.ReactNode | object | (React.ReactNode | object)[] |
There was a problem hiding this comment.
👍 we should put here Extendable as well
There was a problem hiding this comment.
Will put it in the Button PR, as there I will finally have all components so that I can update them accordiongly. That is why I introduced just this type here.
| // Props | ||
| // ======================================================== | ||
|
|
||
| export type ItemShorthand = React.ReactNode | object | (React.ReactNode | object)[] |
3 participants
This PR introduces props interface for the Grid component, as part of #117