This repository was archived by the owner on Mar 4, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 51
This repository was archived by the owner on Mar 4, 2020. It is now read-only.
Add typings for component props #117
Copy link
Copy link
Closed
Labels
vstsPaired with ticket in vstsPaired with ticket in vsts
Description
Feature Request
Problem description
We are missing or have removed props typings in our components.
Proposed solution
See #33 fo the discussion and agreement on this proposal. Let's do this one component and PR at a time to give room for addressing issues that will arise.
- Add props typings only for
handledPropsas this is most helpful to the user. - Make all props interfaces extensible so users can pass any prop value they wish (also aligns with our practice of spreading rest props).
- Provide a
*Strictnamed interface which is not extensible. This allows users to lock allowed props to strictly those supported by the component if they wish, see export element props without [key: string]: any; Semantic-Org/Semantic-UI-React#2836. Our props interfaces will union this interface making it extensible.
TODO
- Accordion feat(Accordion): add props interface #33
- Avatar feat(Avatar): add props interface #129
- Button feat(Props Interfaces): add props interface to Button, AccordionTitle, AccordionContent and refactoring the types definitions #130
- Chat feat(Chat): add props interface #131
- Divider feat(Divider): add props interface #132
- Grid feat(Grid): add props interface #133
- Header feat(Header): add props interface #139
- Icon feat(Icon): add props interface #137
- Image feat(Image): add props interface #147
- Input feat(Input): add props interface #140
- ItemLayout feat(ItemLayout): add props interface and improve props typings #142
- Label feat(Label): add props interface #148
- Layout feat(Layout): add props interface #143
- List feat(List): add props interface #153
- Menu feat(Menu): add prop interfaces #155
- Provider
- Text feat(Text): add prop interfaces #154
- Radio feat(Radio): add props interface #174
- Segment feat(Segment): add props interface #175
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
vstsPaired with ticket in vstsPaired with ticket in vsts