Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

Add typings for component props #117

@levithomason

Description

@levithomason

Feature Request

Problem description

We are missing or have removed props typings in our components.

Proposed solution

See #33 fo the discussion and agreement on this proposal. Let's do this one component and PR at a time to give room for addressing issues that will arise.

  1. Add props typings only for handledProps as this is most helpful to the user.
  2. Make all props interfaces extensible so users can pass any prop value they wish (also aligns with our practice of spreading rest props).
  3. Provide a *Strict named interface which is not extensible. This allows users to lock allowed props to strictly those supported by the component if they wish, see export element props without [key: string]: any; Semantic-Org/Semantic-UI-React#2836. Our props interfaces will union this interface making it extensible.

TODO

Metadata

Metadata

Assignees

No one assigned

    Labels

    vstsPaired with ticket in vsts

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions