Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

fix(Popup): ESC key press on trigger should propagate event if Popup is already closed#1373

Merged
sophieH29 merged 4 commits intomasterfrom
fix/popup-esc-should-propagate-when-popup-closed
May 23, 2019
Merged

fix(Popup): ESC key press on trigger should propagate event if Popup is already closed#1373
sophieH29 merged 4 commits intomasterfrom
fix/popup-esc-should-propagate-when-popup-closed

Conversation

@sophieH29
Copy link
Contributor

If ESC key is pressed on a trigger button and Popup is closed, then this keyboard event should propagate to a parent element.

Use case, in chat pane prototype, in the message, when pressing ESC key on more options button of the attachment:
Expected:

  • if popup open - close popup
  • if popup closed - propagate event, so the focus will go to message container

Actual:
keyboard event is not propagated and focus does not go to the message container

@codecov
Copy link

codecov bot commented May 22, 2019

Codecov Report

Merging #1373 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1373      +/-   ##
==========================================
+ Coverage   72.92%   72.93%   +0.01%     
==========================================
  Files         775      775              
  Lines        5824     5823       -1     
  Branches     1721     1698      -23     
==========================================
  Hits         4247     4247              
+ Misses       1571     1570       -1     
  Partials        6        6
Impacted Files Coverage Δ
packages/react/src/components/Popup/Popup.tsx 68.9% <100%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f33137...8b5a9a8. Read the comment docs.

@sophieH29 sophieH29 merged commit 07cb408 into master May 23, 2019
@sophieH29 sophieH29 deleted the fix/popup-esc-should-propagate-when-popup-closed branch May 23, 2019 09:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants